Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console_scripts entry point is not installed (typo in setup.cfg) #1732

Closed
sstandre opened this issue Mar 6, 2024 · 1 comment · Fixed by #1734
Closed

console_scripts entry point is not installed (typo in setup.cfg) #1732

sstandre opened this issue Mar 6, 2024 · 1 comment · Fixed by #1734
Labels
bug Issue: Something isn't working
Milestone

Comments

@sstandre
Copy link

sstandre commented Mar 6, 2024

There is a typo in setup.cfg that results in novelwriter-cli never being installed.

Setuptools documentation on entry points says that the allowed keys for script entry points under [options.entry_points]are console_scripts and gui_scripts
https://setuptools.pypa.io/en/latest/userguide/entry_point.html

Howerver, setup.cfg uses console_script (without final s) which is not recognized, and so novelwriter-cli is not installed.
https://github.com/vkbo/novelWriter/blob/main/setup.cfg#L44

Given that both novelwriter-cli and novelwriter both point to novelwriter:main it may be superfluous keeping both

@sstandre sstandre added the bug Issue: Something isn't working label Mar 6, 2024
@vkbo
Copy link
Owner

vkbo commented Mar 7, 2024

This is just legacy stuff. The CLI entry point has never been used. The GUI entry point is the one in actual use. I'll just remove it.

The original idea was to avoid spawning a GUI in the CLI case, but this is handled inside the main function anyway, so there's no need for the additional entry point.

@vkbo vkbo added this to the Release 2.3 milestone Mar 7, 2024
vkbo added a commit that referenced this issue Mar 7, 2024
@vkbo vkbo mentioned this issue Mar 7, 2024
6 tasks
@vkbo vkbo closed this as completed in #1734 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue: Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants