Fix for storing table extension field and enumextension values on base table, Make Range and Assignment Explorer work (mostly) with simple pools and other smaller stuff #78

DavidFeldhoff · 2024-07-12T08:56:58Z

Added

New setting fieldAndValueIdsStayInsideObjectRange which makes sure that if you've numbers per object range, e.g. per tableextension, that the field id's stay inside that range as well to avoid conflicts with others.
New setting storeExtensionValuesOrIdsOnBaseObject: With this, reserved object and field numbers are stored on base table/enum level. Currently it's done on tableextension or enumextension level which might lead to conflicts if you've multiple extensions on that same base table/enum. We strongly recommend to activate this setting, but that requires that you update your consumption afterwards e.g. using the Ninja: Automatically Synchronize Object IDs for Entire Workspace command as basically all tableextension field and enumextension value ids are then not considered to be consumed anymore. By activating this setting, the dependencies are loaded using the SymbolReference.json to find out in a fast way the extended object name -> object id relation. The performance impact should not be noticable as it's using as much caching as possible and loads the dependencies already on vscode startup.
Getting the consumption is now done based on app or pool level. This makes the Range Explorer and Assignment Explorer View accessible for App Pools as well. The Lost ids part of the Assignment Explorer is not yet working for pools.
Unassigned and Lost Field diagnostics: In older versions you received diagnostics which showed up in the problems pane if you did not reserve an object id using Ninja. This happens now also for field ids. Furthermore these are warnings are shown in the Assignment Explorer.

Changed

Enumextensions do not get the range from 1-4999 proposed anymore. This practice most likely would result in conflicts sooner or later. Stay inside your id ranges instead or make use of the newly added fieldAndValueIdsStayInsideObjectRange setting.

Fixed

Range Explorer View could not deal with multiple object ranges without a description.
Multiple Object ranges without a description proposed multiple entries as next Ids. Now it only shows the first available one as if the ranges would be one logical range.
An error was shown when reserving an enum value in the range from 1-49999 saying that "no more objects" are available

…with DI

…without description

….50000) for enum values

…thout a valid number)

…tly it would show all object ids of pool apps that are not in the workspace

…onsumption in the change doesn't reflect in the pool view

…etChildrenOfLogicalRangesGroupNode, extract getDescriptionOfRange, add DEFAULT_RANGE_DESCRIPTION

…essible from App

Cache on WorkspaceManager level. Each app loads it's dependencies. Dependency Loading is done by loading the SymbolReference.json from each .app file Whenever the dependencies might be used (e.g. when searching for the base table/enum id), the dependencies are checked if they're up to date. Mostly the cache comes into play then.

…ject` is disabled Add logging in case of failures add xml documentation to some procedures

…use usings?) and fix wrong parser extends-info

…ing yet)

… file were not supported. Using Map<string> instead

… it was way too often not respected, so I guess vjeko did not want to use it.

…ge explorer view for pools

…nged (maybe now part of pool or vice-versa)

…w also supports pools and it has been made less error-prone by turning off some file watchers while switching branches.

…signment

vjekob

Let's try to get this merged. I am really struggling finding time, but this seems ready. There are some mostly cosmetic fixes to this.

I didn't test everything you did, but from what I see, it seems that everyone will have to auto-sync everything again, otherwise their fields/enum values assignments won't work. Correct?

Ninja Azure Back End.code-workspace

Ninja VS Code Extension.code-workspace

azure-function-app/.vscode/settings.json

azure-function-app/src/functions/v2/getNext/types.ts

vscode-extension/src/features/treeView/assignmentExplorer/nodes/AssignmentExplorerRootNode.ts

vscode-extension/src/features/treeView/assignmentExplorer/nodes/CollisionNode.ts

...tension/src/features/treeView/assignmentExplorer/nodes/fieldLostNodes/LostFieldObjectNode.ts

vscode-extension/src/features/treeView/rangeExplorer/RangeExplorerView.ts

…preview.background`

DavidFeldhoff

Hey Vjeko, I fixed your comments so far. I left two comments on "unresolved" simply to have a last look into it, but I would say they can be resolved as well.

I would like to have a call tomorrow or sometime next week with you to talk about it, show what's new now and what to have in mind. E.g. not each company using this app has to resync everything. Only if they activate a setting which fixes the problem that field ids are currently stored incorrectly.

DavidFeldhoff · 2024-10-24T08:54:29Z

vscode-extension/src/features/diagnostics/Diagnostics.ts

@@ -58,29 +60,30 @@ export class Diagnostics implements Disposable {
    //#endregion

    private readonly _diagnostics: DiagnosticCollection;
-    private _documents = new WeakMap<Uri, PropertyBag<Diagnostic[]>>();
-    private _schedulers = new WeakMap<Uri, NodeJS.Timeout>();
+    private _documents = new Map<string, PropertyBag<Diagnostic[]>>();


If I remember correctly then _documents.get(uri) and _documents.delete(uri) wasn't working, so duplicated entries were added. Don't know if I can reproduce it again to make sure that turning it back won't result in an issue. Would rather prefer to leave it like this if that's fine.

Ninja VS Code Extension.code-workspace

azure-function-app/.vscode/settings.json

Ninja Azure Back End.code-workspace

vscode-extension/src/features/treeView/assignmentExplorer/nodes/AssignmentExplorerRootNode.ts

vscode-extension/src/features/treeView/assignmentExplorer/nodes/CollisionNode.ts

...tension/src/features/treeView/assignmentExplorer/nodes/fieldLostNodes/LostFieldObjectNode.ts

vscode-extension/src/features/treeView/rangeExplorer/RangeExplorerView.ts

...tension/src/features/treeView/assignmentExplorer/nodes/fieldLostNodes/LostFieldObjectNode.ts

…n uncompilable state already, then nothing happened.

… available anymore, popped up even if it could fall back to the idRanges of the app.json

David Feldhoff added 30 commits June 6, 2024 10:46

Show multiple entries even if there's no description given

71bf9ef

correcting

d0cac47

Improve "Show multiple entries even if there's no description given" …

25ee188

…with DI

nextIdCompletionProvider should show only one id for multiple Ranges …

20dd06e

…without description

Add fieldAndValueIdsStayInsideObjectRange configuration option

9166e60

Store ExtensionValues on Base Object Id

2107cc0

avoid "No more objects..." error when assigning from public range (1.…

2ab44a1

….50000) for enum values

Do not return Id 1 as valid enumextension value id

2bf9930

Add redirectExtensions

65e303f

Use AppId (app or pool hash) for consumptions

085f4c0

activate managedPools flag

5baca32

include dist and node_modules dir for publishing to Azure Function

7fac2db

Temp Commit for vsixName-change and workspace colors

ef6c78e

Add reminder that ObjIdConfigJson should have nullable properties

ecb0f5c

remove feature flag

6223667

AppPool Consumption in RangeExplorerView

0b717c4

make sure that Assignment Explorer can deal with "codeunit "-file (wi…

3b2fafa

…thout a valid number)

make assignment explorer work with pool, but remove lost nodes as mos…

3f182b2

…tly it would show all object ids of pool apps that are not in the workspace

WIP: Make range explorer work with pool. What's missing: Probably a c…

6803529

…onsumption in the change doesn't reflect in the pool view

Improve view and refactor code: getChildrenOfLogicalObjectTypeNode, g…

49ab1c8

…etChildrenOfLogicalRangesGroupNode, extract getDescriptionOfRange, add DEFAULT_RANGE_DESCRIPTION

Add SymbolReference and load them async in WorkspaceManager, also acc…

39e57a4

…essible from App

avoid processing dependencies when `storeExtensionValuesOrIdsOnBaseOb…

91f3b0a

…ject` is disabled Add logging in case of failures add xml documentation to some procedures

Add changelog

36ed62b

Split ConsumptionDataOfObject and ConsumptionDataOfFields

e14826c

Improve getStorageId and Namepsace using HoverProvider (maybe better …

e76d125

…use usings?) and fix wrong parser extends-info

fix duplicated objects

42a547f

dependencies were loaded again and again

e987df6

change getNamespace using usings

dff5b90

add fieldId diagnostic and storeAssignment (reclaim probably not work…

28492d2

…ing yet)

David Feldhoff added 16 commits July 10, 2024 16:51

Weakmap.Get(uri) doesn't work, so therefore multiple diagnostics in a…

7599cc2

… file were not supported. Using Map<string> instead

Add changelog and readme

84909f8

comply with eslint stuff, but turn off naming-convention and curly as…

836e381

… it was way too often not respected, so I guess vjeko did not want to use it.

remove temporary suffix from package.json-version

6c5ba46

Combine logical ranges, object type ranges and physical ranges in ran…

d0efd41

…ge explorer view for pools

re-load root nodes of range and assignment-explorer if config has cha…

2d16482

…nged (maybe now part of pool or vice-versa)

normal sync command wasn't working anymore

fb90dde

Ninja: Automatically Synchronize Object IDs for Entire Workspace no…

49fe4bf

…w also supports pools and it has been made less error-prone by turning off some file watchers while switching branches.

Show which objects aren't updated on auto-sync

837cceb

Show error log if sync has errors

7bc3d40

Merge dirty docs when creating diagnostics/using Assignment Explorer

c8617d3

Add setting rangesToShowInRangeExplorer

22d2020

Fix getting enum value

f8fb5ac

respect redirectExtensions when storingAssignments

ad896e9

Directly refresh diagnostics and assignmentExplorer after Store ID As…

3516ec9

…signment

2.12.3-david

1d59d6c

DavidFeldhoff force-pushed the master branch from f6673d0 to 1d59d6c Compare September 3, 2024 14:53

vjekob requested changes Oct 19, 2024

View reviewed changes

David Feldhoff added 9 commits October 24, 2024 08:15

Loading packages without source fails, so make it optional

71363ba

2.12.4-david

069d3b7

Exclude "dist" and "node_modules" again

feb2645

Remove color customizations, debug.internalConsoleOptions and `svg.…

089f48e

…preview.background`

GetNextRequest.type = ALObjectType | string

07e23c0

Create own class for temporary parser fix

5a316e4

add curly brackets and create new line after if statements

7ba87cc

Use 2.13.0 as version

5367c52

Write in Ninja output instead of console.log

9c34164

DavidFeldhoff commented Oct 24, 2024

View reviewed changes

David Feldhoff added 2 commits November 14, 2024 16:10

If the symbols cannot be loaded because the project was loaded with a…

a4b16fc

…n uncompilable state already, then nothing happened.

If there's no .objidconfig at all, then the warning that no number is…

0da7e16

… available anymore, popped up even if it could fall back to the idRanges of the app.json

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for storing table extension field and enumextension values on base table, Make Range and Assignment Explorer work (mostly) with simple pools and other smaller stuff #78

Fix for storing table extension field and enumextension values on base table, Make Range and Assignment Explorer work (mostly) with simple pools and other smaller stuff #78

DavidFeldhoff commented Jul 12, 2024

vjekob left a comment

DavidFeldhoff left a comment

DavidFeldhoff Oct 24, 2024

Fix for storing table extension field and enumextension values on base table, Make Range and Assignment Explorer work (mostly) with simple pools and other smaller stuff #78

Are you sure you want to change the base?

Fix for storing table extension field and enumextension values on base table, Make Range and Assignment Explorer work (mostly) with simple pools and other smaller stuff #78

Conversation

DavidFeldhoff commented Jul 12, 2024

Added

Changed

Fixed

vjekob left a comment

Choose a reason for hiding this comment

DavidFeldhoff left a comment

Choose a reason for hiding this comment

DavidFeldhoff Oct 24, 2024

Choose a reason for hiding this comment