Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json import #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AxelEriksson0
Copy link

@AxelEriksson0 AxelEriksson0 commented Nov 20, 2024

With Node 23, using the assert keyword throws error and with should be used instead. See https://nodejs.org/docs/latest-v23.x/api/esm.html#import-attributes

  • Fixing the remaining Deno lint issues.
  • Adding a Deno lint GitHub workflow.

@AxelEriksson0
Copy link
Author

Not sure you get tagged on pull requests so tagging you here @vixalien hope that's fine.

@AxelEriksson0 AxelEriksson0 force-pushed the axeleriksson/fix-json-import branch from 22ba7cc to abc9318 Compare November 20, 2024 23:43
@vixalien
Copy link
Owner

The lint workflow is not working anymore on v2... maybe you need to pass in src

@AxelEriksson0 AxelEriksson0 force-pushed the axeleriksson/fix-json-import branch from abc9318 to 631c1b1 Compare November 23, 2024 22:55
@AxelEriksson0 AxelEriksson0 force-pushed the axeleriksson/fix-json-import branch from 631c1b1 to 7e722b1 Compare November 23, 2024 22:57
@AxelEriksson0
Copy link
Author

The lint workflow is not working anymore on v2... maybe you need to pass in src

I forgot to checkout the code in the GitHub workflow. Should be fixed now @vixalien

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants