fix: crashing on files with undefined duration.

addresses #21
vixalien · Jan 31, 2024 · 57aa61b · 57aa61b
1 parent 0a49c37
commit 57aa61b
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/src/stream.ts b/src/stream.ts
@@ -473,7 +473,7 @@ export class APMediaStream extends Gtk.MediaStream {
   get_duration() {
     if (!this._play.media_info) return 0;
 
-    return this._play.media_info.get_duration() / Gst.USECOND;
+    return get_safe_duration(this._play.media_info.get_duration()) / Gst.USECOND;
   }
 
   // property: error
@@ -622,7 +622,7 @@ export class APMediaStream extends Gtk.MediaStream {
         info.get_number_of_audio_streams() > 0,
         info.get_number_of_video_streams() > 0,
         info.is_seekable(),
-        this._play.get_duration() / Gst.USECOND,
+        get_safe_duration(info.get_duration()) / Gst.USECOND,
       );
 
       if (info.get_number_of_audio_streams() <= 0) {
@@ -634,6 +634,8 @@ export class APMediaStream extends Gtk.MediaStream {
           ),
         );
       }
+    } else {
+      this.notify("duration");
     }
   }
 
@@ -761,3 +763,11 @@ export function get_cubic_volume(value: number) {
     value,
   );
 }
+
+function get_safe_duration(value: number) {
+  if (value >= GLib.MAXUINT64) {
+    return 100 * Gst.SECOND;
+  }
+
+  return value;
+}