Add converters

[ikalinin1]

No description provided.

[uarlouski]

why is it called bean?

[ikalinin1]

any concerns?

[uarlouski]

These guys have lots of concerns

[uarlouski]

if seriously this name says nothing about mission of this class

[ikalinin1]

This is just a bean

[ikalinin1]

I can use your name if you have a good one, am I?

[uarlouski]

Name of class should give some idea about why this class is needed https://www.oracle.com/technetwork/java/codeconventions-135099.html

[ikalinin1]

So, what's your pick for pojo with fields?

[uarlouski]

at least the name should reflect somehow that this bean holds fields set to values passed through spring converters

[ikalinin1]

Like any other bean covered for us by spring :)

[codecov]

Codecov Report

Merging #185 (effd7a4) into master (6dbf573) will decrease coverage by 1.17%.
The diff coverage is 100.00%.

❗ Current head effd7a4 differs from pull request most recent head f598418. Consider uploading reports for the commit f598418 to get more accurate results

@@             Coverage Diff              @@
##             master     #185      +/-   ##
============================================
- Coverage     94.57%   93.39%   -1.18%     
+ Complexity     4212     3615     -597     
============================================
  Files           548      469      -79     
  Lines         11481     9818    -1663     
  Branches        858      786      -72     
============================================
- Hits          10858     9170    -1688     
- Misses          487      507      +20     
- Partials        136      141       +5     

Impacted Files	Coverage Δ
...erlyInitializingPropertyEditorRegistrySupport.java	100.00% <100.00%> (ø)
...vividus/spring/StringToEditorGenericConverter.java	100.00% <100.00%> (ø)
...c/main/java/org/vividus/bdd/model/MetaWrapper.java	33.33% <0.00%> (-61.41%)	⬇️
.../org/vividus/bdd/steps/WebUiVividusSetupSteps.java	41.66% <0.00%> (-47.23%)	⬇️
...idus/bdd/transformer/ExtendedTableTransformer.java	55.00% <0.00%> (-45.00%)	⬇️
...ava/org/vividus/ui/web/event/PageLoadEndEvent.java	66.66% <0.00%> (-33.34%)	⬇️
...g/vividus/runner/VividusInitializationChecker.java	67.85% <0.00%> (-32.15%)	⬇️
...ava/org/vividus/http/client/SslContextFactory.java	70.83% <0.00%> (-29.17%)	⬇️
.../main/java/org/vividus/bdd/variable/Variables.java	71.42% <0.00%> (-28.58%)	⬇️
...g/vividus/softassert/model/SoftAssertionError.java	62.50% <0.00%> (-25.00%)	⬇️
... and 393 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbf573...f598418. Read the comment docs.

[valfirst]

Waiting for decision regarding spring-projects/spring-framework#24311

[ghost]

Congratulations 🎉. DeepCode analyzed your code in 2.696 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

[valfirst]

Keep it open until PR to Spring is not resolved

[valfirst]

Superseded by other pull requests