[hostcfgd] Fixed the brief blackout in hostcfgd using SubscriberStateTable #16

vivekrnv · 2021-09-08T07:51:08Z

Why I did it

Fixes the issue sonic-buildimage/issues/8619.

How I did it

Listening to CFG_DB notifications was migrated from ConfigDBConnector to SubscriberStateTable & Select
This change in design helped me to remove update_all_features_config which was roughly taking a 5-10 sec time to execute and thus the reason for blackout
Edited FeatureHandler, Feature & NtpCfgd classes to suit this design
Added corresponding mocks and UT's

How to verify it

UT's:

tests/determine-reboot-cause_test.py .........                                                                                                                                                                                        [ 29%]
tests/procdockerstatsd_test.py .                                                                                                                                                                                                      [ 32%]
tests/caclmgrd/caclmgrd_dhcp_test.py ......                                                                                                                                                                                           [ 51%]
tests/hostcfgd/hostcfgd_radius_test.py ..                                                                                                                                                                                             [ 58%]
tests/hostcfgd/hostcfgd_test.py .............                                                                                                                                                                                         [100%]

Verified manually,

Sep 10 22:53:25.662621 sonic INFO systemd[1]: hostcfgd.service: Succeeded.
Sep 10 22:55:04.127719 sonic INFO /hostcfgd: ConfigDB connect success
Sep 10 22:55:04.128108 sonic INFO /hostcfgd: KdumpCfg init ...
Sep 10 22:55:04.148819 sonic INFO /hostcfgd: Waiting for systemctl to finish initialization
Sep 10 22:55:04.163452 sonic INFO /hostcfgd: systemctl has finished initialization -- proceeding ...
Sep 10 22:55:04.163834 sonic INFO /hostcfgd: Kdump handler...
Sep 10 22:55:04.164019 sonic INFO /hostcfgd: Kdump global configuration update
Sep 10 22:55:04.758784 sonic INFO hostcfgd[184471]: kdump is already disabled
Sep 10 22:55:04.758876 sonic INFO hostcfgd[184471]: Kdump is already disabled
Sep 10 22:55:05.182021 sonic INFO hostcfgd[184511]: Kdump configuration has been updated in the startup configuration
Sep 10 22:55:05.596919 sonic INFO hostcfgd[184528]: Kdump configuration has been updated in the startup configuration
Sep 10 22:55:06.140627 sonic INFO /hostcfgd: Feature nat is stopped and disabled
Sep 10 22:55:06.642629 sonic INFO /hostcfgd: Feature telemetry is enabled and started
Sep 10 22:55:07.101297 sonic INFO /hostcfgd: Feature pmon is enabled and started
Sep 10 22:55:07.554366 sonic INFO /hostcfgd: Feature database is enabled and started
Sep 10 22:55:08.009329 sonic INFO /hostcfgd: Feature mgmt-framework is enabled and started
Sep 10 22:55:08.394952 sonic INFO /hostcfgd: Feature macsec is stopped and disabled
Sep 10 22:55:08.782853 sonic INFO /hostcfgd: Feature snmp is enabled and started
Sep 10 22:55:09.205381 sonic INFO /hostcfgd: Feature teamd is enabled and started
Sep 10 22:55:09.224877 sonic INFO /hostcfgd: Feature what-just-happened is enabled and started
Sep 10 22:55:09.627929 sonic INFO /hostcfgd: Feature lldp is enabled and started
Sep 10 22:55:10.086993 sonic INFO /hostcfgd: Feature swss is enabled and started
Sep 10 22:55:10.170312 sonic INFO /hostcfgd: cmd - service aaastatsd stop
Sep 10 22:55:11.012236 sonic INFO /hostcfgd: cmd - service aaastatsd stop
Sep 10 22:55:12.225946 sonic INFO /hostcfgd: Feature bgp is enabled and started
Sep 10 22:55:12.712792 sonic INFO /hostcfgd: Feature dhcp_relay is enabled and started
Sep 10 22:55:13.166656 sonic INFO /hostcfgd: Feature sflow is stopped and disabled
Sep 10 22:55:13.593639 sonic INFO /hostcfgd: Feature radv is enabled and started
Sep 10 22:55:14.034106 sonic INFO /hostcfgd: Feature syncd is enabled and started
Sep 10 22:55:14.113064 sonic INFO /hostcfgd: cmd - service aaastatsd stop
Sep 10 22:55:14.863601 sonic INFO /hostcfgd: RADIUS_SERVER update: key: 10.10.10.1, op: SET, data: {'auth_type': 'pap', 'passkey': 'p*****', 'retransmit': '1', 'timeout': '1'}
Sep 10 22:55:14.938605 sonic INFO /hostcfgd: cmd - service aaastatsd stop
Sep 10 22:55:15.667545 sonic INFO /hostcfgd: RADIUS_SERVER update: key: 10.10.10.3, op: SET, data: {'auth_type': 'chap', 'passkey': 'p*****', 'retransmit': '2', 'timeout': '2'}
Sep 10 22:55:15.667801 sonic INFO /hostcfgd: RADIUS (NAS) IP change - key:eth0, current global info {}
Sep 10 22:55:15.746531 sonic INFO /hostcfgd: cmd - service aaastatsd stop
Sep 10 23:04:47.435340 sonic INFO /hostcfgd: ntp server update key 0.debian.pool.ntp.org
Sep 10 23:04:47.435661 sonic INFO /hostcfgd: ntp server update, restarting ntp-config, ntp servers configured {'0.debian.pool.ntp.org'}
Sep 10 23:04:47.866394 sonic INFO /hostcfgd: NTP GLOBAL Update
Sep 10 23:04:47.866557 sonic INFO /hostcfgd: ntp global update for source intf old {''} new {'eth0', 'Loopback0'}, restarting ntp-config
Sep 10 23:16:25.157600 sonic INFO /hostcfgd: Running cmd: 'sudo systemctl unmask sflow.service'
Sep 10 23:16:25.178472 sonic INFO hostcfgd[192106]: Removed /etc/systemd/system/sflow.service.
Sep 10 23:16:25.582018 sonic INFO /hostcfgd: Running cmd: 'sudo systemctl enable sflow.service'
Sep 10 23:16:25.604534 sonic INFO hostcfgd[192123]: Created symlink /etc/systemd/system/sonic.target.wants/sflow.service → /lib/systemd/system/sflow.service.
Sep 10 23:16:26.029416 sonic INFO /hostcfgd: Running cmd: 'sudo systemctl start sflow.service'
Sep 10 23:16:26.691927 sonic INFO /hostcfgd: Feature sflow is enabled and started

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Vivek Reddy Karri <[email protected]>

src/sonic-host-services/scripts/hostcfgd

stepanblyschak · 2021-09-13T13:33:59Z

src/sonic-host-services/scripts/hostcfgd

+        try:
+            ret = ast.literal_eval(val)
+        except Exception as e:
+            ret = False


The default value is recorded in two places, one is here, one in the line: self.__safe_eval_bool(feature_cfg.get('has_timer', 'False'))

The idea is, if the user programs something, invalid apart from True or False, this shouldn't fail.

If the user programs anything other than ''True", the value is set to False

stepanblyschak · 2021-09-13T13:35:06Z

src/sonic-host-services/scripts/hostcfgd

-from swsscommon.swsscommon import ConfigDBConnector
+from sonic_py_common.device_info import is_multi_npu, get_num_npus
+from swsscommon.swsscommon import SubscriberStateTable, DBConnector, Select
+from swsscommon.swsscommon import ConfigDBConnector, TableConsumable


Do you still need ConfigDBConnector?

Yes, i'm still using that for non-active listener use cases. The active listener responsibility is transferred to SubscriberStateTable

What is the difference between active/non-active listeners?

Sorry, i haven't framed it properly. I meant, i did not change some of the existing code which fetches tables from the DB . Eg: https://github.com/vivekreddynv/sonic-buildimage/blob/1d626893843cd4514494f280fa7c1eb1159f002c/src/sonic-host-services/scripts/hostcfgd#L905

src/sonic-host-services/scripts/hostcfgd

stepanblyschak · 2021-09-13T13:47:02Z

src/sonic-host-services/scripts/hostcfgd


 class HostConfigDaemon:
    def __init__(self):
+        # Just a sanity check to verify if the CONFIG_DB has been initialized
+        # before moving forward


Why do we need this explicitelly?

This was present before my changes ,i've just retained it.

I wonder if we can remove it, those daemons that use swsscommon.SubscriberStateTable don't use ConfigDBConnector's wait_for_init.

This was probably added because this script used to start very early, and the implementers wanted to wait until the CONFIG_DB is initialized/redis is up. Although, you may argue that this can be removed. But since it doesn't affect anything, i think it's better to have as a sanity check.

https://github.com/Azure/sonic-swss-common/blob/master/common/configdb.cpp#L28

stepanblyschak · 2021-09-13T13:49:36Z

src/sonic-host-services/scripts/hostcfgd

+            for callback in cbs:
+                callback(table, key, op, dict(fvs))
+
+            if init_load_flag and table == "FEATURE" and key.lower() == "swss":


What is the purpose of this condition?

Previously, before the listen phase was started, update_all_features_config was run followed by load . This inturn invokes the load method of AaaCfg.

With the redesign, we cannot have the manual ordering which we had previously, thus introduced this condition i.e. to basically execute the load of aaacfg after swss is started

Why AAA config depends on FEATURE config?

AAA/RADIUS/TACACS tables, have src_intf option which could be configured as either eth0, Loopback0 etc.

https://github.com/Azure/SONiC/blob/master/doc/aaa/radius_authentication.md#radius-table-schema

Before this change, AAA config was run after the FEATURE config is completed

So, i thought of retaining this order by configuring SWSS first and then AAA. but if you think it's safe to confiure AAA before feature config, then i can change this.

You're saying that AAA/RADIUS/TACACS need to have an interface to work with, which could be management interface or loopback interface which is created by swss and this is why swss has to be started first and then AAA configuration processed?
If it is, I would suggest removing this condition, since it anyway does not guarantee that Loopback interface will be created at this time.

stepanblyschak · 2021-09-13T13:50:01Z

src/sonic-host-services/setup.py

@@ -27,7 +27,7 @@
        'Jinja2>=2.10',
        'PyGObject',
        'sonic-py-common',
-        'systemd-python',
+        'systemd-python'


Haven't seen it actually in use

src/sonic-host-services/scripts/hostcfgd

Signed-off-by: Vivek Reddy Karri <[email protected]>

…buildimage into hostcfgd_fix

vivekrnv · 2021-09-16T05:44:31Z

@stepanblyschak, Addressed suggestion and provided comments on few of them. Please review

Signed-off-by: Vivek Reddy Karri <[email protected]>

* [BFN] Updated platform APIs impl Signed-off-by: Andriy Kokhan <[email protected]> * Extended BFN platform SFP APIs implementation * Update sfp.py * [BFN] Extended SFP platform plugin implementation Signed-off-by: Andriy Kokhan <[email protected]> * [BFN] Extended Fans platform plugin implementation * [BFN] divided classes Fan and FanDrawer into 2 files * Signed-off-by: Vadym Yashchenko <[email protected]> What I did Add get_model() function Add get_low_critical_threshold() function Change __get(...) function. How I did it Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API * Add get_presence() function and revised __get() function Signed-off-by: Vadym Yashchenko <[email protected]> * [BFN] Updated PSU platform APIs impl Signed-off-by: Dmytro Lytvynenko <[email protected]> * Added BFN PSU cache (#9) Signed-off-by: Andriy Kokhan <[email protected]> * [BFN] Fans and Fantray platform APIs update (#7) * [BFN] Updated SFP platform APIs (#10) Signed-off-by: Volodymyr Boyko <[email protected]> * [BFN] Updated platform API for thermal (#8) * Signed-off-by: Vadym Yashchenko <[email protected]> * Revert "[BFN] Fans and Fantray platform APIs update (#7)" (#11) This reverts commit c62a733. * Add support health monitor system (#15) Signed-off-by: Petro Bratash <[email protected]> * Update chassis.py * [BFN] Updated FANs and FAN Tray platform API (#14) * Fix fix_alignment (#17) Signed-off-by: Petro Bratash <[email protected]> * [BFN] Improvement show environment (#16) * Added PSU temperature skip into platform.json (#18) Signed-off-by: Andriy Kokhan <[email protected]> * Do not skip psud on Newport Signed-off-by: Andriy Kokhan <[email protected]> * [BFN] fix fan status from Not OK to Ok (#19) * [BFN] Updated SFP platform plugin (#13) Signed-off-by: Volodymyr Boyko <[email protected]> * [DPB] Fix typo for Ethernet0 2x200G[100G,40G] breakout mode (#21) Signed-off-by: Mykola Gerasymenko <[email protected]> * [barefoot] Tmp fix vendor_rev (#22) Signed-off-by: Volodymyr Boyko <[email protected]> * Fixed python issues in sonic_platform/fan_drawer.py Signed-off-by: Andriy Kokhan <[email protected]> * Updated fan_drawer.py * Fixing trailing white spaces in fan_drawer.py * [BFN] Fix thrift for SFPs API Signed-off-by: Volodymyr Boyko <[email protected]> * In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue Signed-off-by: Andriy Kokhan <[email protected]> * [Newport] Thermal manager (#23) * Signed-off-by: Vadym Yashchenko <[email protected]> * Revert "In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue" This reverts commit 1e73127. * Removed 'controllable' options from platform.json to fix factory default config generation Signed-off-by: Andriy Kokhan <[email protected]> * Update thermal_manager.py * Migrated SFP plugin to sonic_xcvr API (#30) Signed-off-by: Andriy Kokhan <[email protected]> Co-authored-by: KostiantynYarovyiBf <[email protected]> Co-authored-by: Vadym Yashchenko <[email protected]> Co-authored-by: Dmytro Lytvynenko <[email protected]> Co-authored-by: Volodymyr Boiko <[email protected]> Co-authored-by: Petro Bratash <[email protected]> Co-authored-by: Mykola Gerasymenko <[email protected]>

[sonic-linkmgrd][master] submodule update Commits added: 0c23756 Jing Zhang 2022-01-19 Linkmgrd subscribing State DB route event (#13) 12b9951 Longxiang Lyu 2021-12-13 Add TLV support to ICMP payload (#11) 3eedda3 Longxiang Lyu 2022-01-06 Add missing intermediate states (#16) 8da4982 Ying Xie 2022-01-04 [linkmgrd] update README, set coding style guidance (#15) a897cf8 Longxiang Lyu 2021-12-13 Improve PR template (#16) 6fec701 Jing Zhang 2021-12-06 Add pull request template for linkmgrd repo (#9) signed-off-by: Jing Zhang [email protected]

#### Why I did it Update sonic-host-services submodule to include below commits: ``` bc8698d Merge pull request #21 from abdosi/feature 557a110 Fix the issue where if dest port is not specified in ACL rule than for multi-asic where we create NAT rule to forward traffic from Namespace to host fail with exception. 6e45acc (master) Merge pull request #14 from abdosi/feature 4d6cad7 Merge remote-tracking branch 'upstream/master' into feature bceb13e Install libyang to azure pipeline (#20) 82299f5 Merge pull request #13 from SuvarnaMeenakshi/cacl_fabricns 15d3bf4 Merge branch 'master' into cacl_fabricns de54082 Merge pull request #16 from ZhaohuiS/feature/caclmgrd_external_client_warning_log b4b368d Add warning log if destination port is not defined d4bb96d Merge branch 'master' into cacl_fabricns 35c76cb Add unit-test and fix typo. 17d44c2 Made Changes to be Python 3.7 compatible 978afb5 Aligning Code 1fbf8fb Merge remote-tracking branch 'upstream/master' into feature 7b8c7d1 Added UT for the changes 91c4c42 Merge pull request #9 from ZhaohuiS/feature/caclmgrd_external_client 7c0b56a Add 4 test cases for external_client_acl, including single port and port range for ipv4 and ipv6 b71e507 Merge remote-tracking branch 'origin/master' into HEAD d992dc0 Merge branch 'master' into feature/caclmgrd_external_client bd7b172 DST_PORT is configuralbe in json config file for EXTERNAL_CLIENT_ACL f9af7ae [CLI] Move hostname, mgmt interface/vrf config to hostcfgd (#2) 70ce6a3 Merge pull request #10 from sujinmkang/cold_reset 29be8d2 Added Support to render Feature Table using Device running metadata. Also added support to render 'has_asic_scope' field of Feature Table. 3437e35 [caclmgrd][chassis]: Add ip tables rules to accept internal docker traffic from fabric asic namespaces. 8720561 Fix and add hardware reboot cause determination tests 0dcc7fe remove the empty bracket if no hardware reboot cause minor e47d831 fix the wrong expected result comparision ef86b53 Fix startswith Attribute error 8a630bb fix mock patch 8543ddf update the reboot cause logic and update the unit test 53ad7cd fix the mock patch function 7c8003d fix the reboot-cause regix for test 1ba611f fix typo 25379d3 Add unit test case a56133b Add hardware reboot cause as actual reboot cause for soft reboot failed c7d3833 Support Restapi/gnmi control plane acls f6ea036 caclmgrd: Don't block traffic to mgmt by default a712fc4 Update test cases adc058b caclmgrd: Don't block traffic to mgmt by default 06ff918 Merge pull request #7 from bluecmd/patch-1 e3e23bc ci: Rename sonic-buildimage repository e83a858 Merge pull request #4 from kamelnetworks/acl-ip2me-test f5a2e50 [caclmgrd]: Tests for IP2ME rules generation ```

* Enable iproute2 as the SDK is also built Signed-off-by: Vivek Reddy <[email protected]> * [Nvidia] Dont use mkbmdeb method of dkms to build the package Signed-off-by: Vivek Reddy <[email protected]> * Include mft into the bookworm build Signed-off-by: Vivek Reddy <[email protected]> * Added linux image to the Depends section of mft Signed-off-by: Vivek Reddy <[email protected]> --------- Signed-off-by: Vivek Reddy <[email protected]>

Signed-off-by: Vivek Reddy <[email protected]> [Nvidia] Enable iproute2 & fix mft build (#16) * Enable iproute2 as the SDK is also built Signed-off-by: Vivek Reddy <[email protected]> * [Nvidia] Dont use mkbmdeb method of dkms to build the package Signed-off-by: Vivek Reddy <[email protected]> * Added linux image to the Depends section of mft Signed-off-by: Vivek Reddy <[email protected]> [Nvidia] [Bookworm] Separate KERNEL_MFT into a new target (sonic-net#16782) * [Nvidia] Seperate KERNEL_MFT into a new target because of kernel header dependency Signed-off-by: Vivek Reddy <[email protected]> * Update linux-kernel submodule Signed-off-by: Vivek Reddy <[email protected]> * Fix paralell build problem Signed-off-by: Vivek Reddy <[email protected]> --------- Signed-off-by: Vivek Reddy <[email protected]>

* [build] Fix bfinstall and bootimages packages URLs. * [build] Fix issue with "bootimages" package dependencies.

…sonic-net#17750) #### Why I did it src/dhcpmon ``` * 2443073 - (HEAD -> 202311, origin/202311) [counter] Clear counter table when dhcpmon init (#14) (#16) (2 days ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog

…ly (sonic-net#20955) #### Why I did it src/sonic-bmp ``` * 4dcef92 - (HEAD -> master, origin/master, origin/HEAD) Merge pull request #16 from FengPan-Frank/fix1 (25 hours ago) [Feng-msft] * 4735a94 - Bug fixing during integration test (35 hours ago) [Feng Pan] ``` #### How I did it #### How to verify it #### Description for the changelog

vivekrnv added 10 commits September 3, 2021 22:19

hostcfgd fix in prog

1dcbe06

Signed-off-by: Vivek Reddy Karri <[email protected]>

AAA tables edited

799943d

Signed-off-by: Vivek Reddy Karri <[email protected]>

Ntpcfg & Iptables updated

484f66a

Signed-off-by: Vivek Reddy Karri <[email protected]>

Feature handler and UT's completed

fd28bb4

Signed-off-by: Vivek Reddy Karri <[email protected]>

AAA & RADIUS test in prog

02741a1

Signed-off-by: Vivek Reddy Karri <[email protected]>

NtpCfg Completed, AaaCfgd is progress

50ff897

Signed-off-by: Vivek Reddy Karri <[email protected]>

UT in progress

7535f74

Signed-off-by: Vivek Reddy Karri <[email protected]>

Added tests for HostcfgDaemon and mocks

3da47d3

Signed-off-by: Vivek Reddy Karri <[email protected]>

Minor fixes

31c6ec7

Signed-off-by: Vivek Reddy Karri <[email protected]>

Merge COnflicts resolved

87d910b

Signed-off-by: Vivek Reddy Karri <[email protected]>

vivekrnv changed the title ~~Hostcfgd fix [In Prog] [Don't Review]~~ [hostcfgd] Fixes the brief blackout in hostcfgd by migration to SubscriberStateTable Sep 10, 2021

vivekrnv changed the title ~~[hostcfgd] Fixes the brief blackout in hostcfgd by migration to SubscriberStateTable~~ [hostcfgd] Fixed the brief blackout in hostcfgd using SubscriberStateTable Sep 10, 2021

vivekrnv and others added 4 commits September 10, 2021 22:43

Changes to Aaacfg cleared

4e74f51

Signed-off-by: Vivek Reddy Karri <[email protected]>

Removed Unnecessary Files and imports

85d01aa

Signed-off-by: Vivek Reddy Karri <[email protected]>

Removed unnecessary methods in hostcfgd

e2684b6

Signed-off-by: Vivek Reddy Karri <[email protected]>

Update mock_configdb.py

1d62689

stepanblyschak suggested changes Sep 13, 2021

View reviewed changes

vivekrnv added 3 commits September 16, 2021 05:40

Added signal handler and other comments handled

f451ed4

Signed-off-by: Vivek Reddy Karri <[email protected]>

Broad Exception handled

b3df6f6

Signed-off-by: Vivek Reddy Karri <[email protected]>

Merge branch 'hostcfgd_fix' of https://github.com/vivekreddynv/sonic-…

51670c3

…buildimage into hostcfgd_fix

Removed init dependency of AAA on swss

c17c8f4

Signed-off-by: Vivek Reddy Karri <[email protected]>

stepanblyschak approved these changes Sep 27, 2021

View reviewed changes

vivekrnv closed this Sep 28, 2021

vivekrnv pushed a commit that referenced this pull request Mar 18, 2024

[build] Fix bluefield packages compilation. (#16)

6a537b0

* [build] Fix bfinstall and bootimages packages URLs. * [build] Fix issue with "bootimages" package dependencies.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[hostcfgd] Fixed the brief blackout in hostcfgd using SubscriberStateTable #16

[hostcfgd] Fixed the brief blackout in hostcfgd using SubscriberStateTable #16

vivekrnv commented Sep 8, 2021 •

edited

Loading

stepanblyschak Sep 13, 2021

vivekrnv Sep 16, 2021

stepanblyschak Sep 13, 2021

vivekrnv Sep 13, 2021

stepanblyschak Sep 14, 2021

vivekrnv Sep 14, 2021 •

edited

Loading

stepanblyschak Sep 13, 2021

vivekrnv Sep 14, 2021 •

edited

Loading

stepanblyschak Sep 14, 2021

vivekrnv Sep 15, 2021

stepanblyschak Sep 13, 2021

vivekrnv Sep 13, 2021 •

edited

Loading

stepanblyschak Sep 14, 2021

vivekrnv Sep 14, 2021 •

edited

Loading

stepanblyschak Sep 23, 2021

vivekrnv Sep 27, 2021

stepanblyschak Sep 13, 2021

vivekrnv commented Sep 16, 2021

[hostcfgd] Fixed the brief blackout in hostcfgd using SubscriberStateTable #16

[hostcfgd] Fixed the brief blackout in hostcfgd using SubscriberStateTable #16

Conversation

vivekrnv commented Sep 8, 2021 • edited Loading

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vivekrnv Sep 14, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vivekrnv Sep 14, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vivekrnv Sep 13, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vivekrnv Sep 14, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vivekrnv commented Sep 16, 2021

vivekrnv commented Sep 8, 2021 •

edited

Loading

vivekrnv Sep 14, 2021 •

edited

Loading

vivekrnv Sep 14, 2021 •

edited

Loading

vivekrnv Sep 13, 2021 •

edited

Loading

vivekrnv Sep 14, 2021 •

edited

Loading