Make writer field of RPCReceiver public. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need this in Dagger to create an implementation of buildkit session attachable that wraps RPCReceiver. Signed-off-by: Erik Sipsma <[email protected]>
|
Oh gotcha - so you just need a way to manually construct a I think I would prefer a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need this in Dagger to create an implementation of buildkit session attachable that wraps RPCReceiver.
@vito here's where it's used in the session frontend PR: dagger/dagger@22af8f0#diff-a92e280e12097c7a058672dc80551529f7dfed8e9001beeff1109d518a0e89d0R422-R450
Kind of neat in that because progrock uses grpc, we can just directly attach the client/server over the session's grpc conn and forward events from graphql server back to client(s).