major API and UI revision #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* reimplement UI from scratch * use protobuf for protocol messages * introduce Casette for recording and displaying progress
This reverts commit 3655ec0.
first stab at a git log -like UI for viewing groups. topological order is just...too confusing. it was needed because we don't always have a 'start time', due to pending vertices, but the UX is pretty bad. it's easier to just skip pending vertexes and sort chronologically.
otherwise you'd see the round corner and a blank group name at the start, which is weird
this handles the situation where a group was created and a child group was also created before a vertex was added to the parent group
Previously it was a solid horizontal line passing through dotted vertical lines, which didn't really sell an illusion. Now we combine vlBar (|-) and hdBar (- ) to form a dotted-line illusion.
much easier to see, and kind of looks like guitar hero
red is too spooky, and the upper echelons of the 16 color palette look janky
Gotta give them a chance for subgroups to show up.
Using color for both the groups and the vertex names was too confusing because they would sometimes match but it was purely incidental. Now we'll place ERROR/CACHED/CANCELED at the start, so they all line up, and give them their own color. Running timestamps are now yellow too.
...i think the goal is to use the colorful shades (1-7) but not start with red, because it's spooky.
Dagger doesn't have a concept of 'completing' a pipeline. Instead we just complete the recorder when the session ends, which completes all the groups. So without this, everything just piles up. This shouldn't be needed anymore now that groups will re-introduce their parents when needed.
helps deal with big Dockerfile RUNs
...this is actually broken on its own, refactored a bit too much at once, whoopsie
Recorder will now keep track of groups associated to vertex digests, globally to the recorder. Whenever an update is recorded, all vertex groups will be expanded to the union of all groups ever seen by the recorder. This goes for both the Go API and direct calls to Record (as when converting SolveStatuses from Buildkit).
* dashes on the right instead of on the left * bolder |- for tasks
makes it flush with the thick terminal bar. overall cue now is bold lines = active vertex.
ideally we would make the whole line bold, but there's no "bold curved corner" character. but this is a decent compromise; you can argue it's correct because it represents the spawning time before the other group is active.
this is a flaky deadlock waiting to happen; the infinite buffered version is better. for other use cases you can implement your own Writer.
+ fix up some boolean logic precedence
* get rid of dashed lines from active vertex across the goal of this was to draw your eye to the active item, but it also just caused a ton of noise and made the actual horizontal lines hard to see * use fancy unicode for arrowheads attempted to show dependencies for non-adjacent siblings, but skipped for now, makes things too ugly. maybe for a super verbose mode?
* partition vertexes into completed/running and render in one loop
* prevents all the groups from being rendered offscreen for running
vertexes
* fix rendering arrowhead/line when vertex has inputs on both sides
adaptive colors appear to cause the terminal to hang with lipgloss v0.7.1
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the Buildkit-based UI with a fully rewritten
git log --graphstyle UI:Switch to Protobuf for the protocol types, so progress messages can be sent over e.g. gRPC.
Introduce
canceledvertex state.Introduce
internalvertex flag, hidden in the UI by default.Introduce infinite buffered pipe, to eliminate deadlocks.
Introduce groups which vertexes can be members of.