Skip to content

Commit

Permalink
refactor to fix empty image export/publishes
Browse files Browse the repository at this point in the history
This is sorely lacking test coverage. Probably need a test that exports
and imports again.

But it's not possible to import a host path yet.
  • Loading branch information
vito committed Apr 11, 2023
1 parent b9e7312 commit 3ec9b13
Show file tree
Hide file tree
Showing 5 changed files with 230 additions and 180 deletions.
2 changes: 1 addition & 1 deletion bass/bass.bass
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
($ cp -a & $submodule-cp-args)
($ go mod download)))))

(provide [build smoke-test tests docs coverage]
(provide [build dist smoke-test tests docs coverage]
(use (*dir*/buildkit.bass))

(defn dist [src version os arch]
Expand Down
3 changes: 0 additions & 3 deletions cmd/bass/frontend.go
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,6 @@ func frontendBuild(ctx context.Context, gw gwclient.Client) (*gwclient.Result, e
ib, err := builder.Build(
ctx,
thunk,
func(st llb.ExecState, sourcePath string) llb.State {
return st.Root()
},
false, // don't run any entrypoint
)
if err != nil {
Expand Down
Loading

0 comments on commit 3ec9b13

Please sign in to comment.