-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: resolve retry.condition RegExp serialization issue
#9942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+118
−6
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dafba6a
fix: resolve `retry.condition` RegExp serialization issue
nstepien 97b79aa
move test
nstepien 79be2ab
consistent `#test-utils` import
nstepien f0a65b9
remove newline for consistency
nstepien 5e99433
revert alias import changes
nstepien 6df093c
test: consolidate
hi-ogawa 809fdd4
Merge branch 'main' into main
hi-ogawa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { expect, test } from 'vitest' | ||
| import { runInlineBrowserTests } from './utils' | ||
|
|
||
| test('test.retry.condition is corrrectly serialized', async () => { | ||
| const { stderr, results } = await runInlineBrowserTests({ | ||
| 'basic.test.js': /* js */` | ||
| import { expect, test } from 'vitest' | ||
|
|
||
| test('task.retry.condition is corrrectly deserialized', ({ task }) => { | ||
| expect(task.retry.condition).toBeInstanceOf(RegExp) | ||
| expect(task.retry.condition).toStrictEqual(/retry_this/) | ||
| }) | ||
| `, | ||
| }, { | ||
| retry: { | ||
| condition: /retry_this/, | ||
| }, | ||
| }) | ||
| expect(stderr).toBe('') | ||
| for (const result of results) { | ||
| expect(result.state()).toBe('passed') | ||
| } | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.