fix(core): prevent starting new run when cancelling #8991
Merged
+56
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriPerkkio
changed the title
bail: 1 race condition test
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
commented
Nov 10, 2025
Comment on lines
+29
to
+30
| // No "Error: [vitest-pool]: Cannot run tasks while pool is cancelling" errors should show up | ||
| expect(errors).toHaveLength(0) |
Member
Author
There was a problem hiding this comment.
Example failure without the fix:
7 tasks
sheremet-va
reviewed
Nov 10, 2025
sheremet-va
previously approved these changes
Nov 10, 2025
Member
sheremet-va
left a comment
sheremet-va
left a comment
There was a problem hiding this comment.
Can't we merge both solutions? 😄
AriPerkkio
force-pushed
the
fix/cancel-race-condition
branch
from
70e8838 to
503d506
Compare
Member
Author
I would rather not have this logic on multiple levels. And it would be good to see pool throwing the error when But feel free to choose one or both. |
Contributor
|
I don't mind as long as it's fixed |
Contributor
|
Any way we can get this merged? |
AriPerkkio
force-pushed
the
fix/cancel-race-condition
branch
from
503d506 to
5dc88d2
Compare
sheremet-va
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative for #8971.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.