Skip to content

fix(happy-dom): properly teardown additional keys #8888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

fix(happy-dom): properly teardown additional keys #8888

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64217cc
fix(happy-dom): properly teardown additional keys
sheremet-va Oct 31, 2025
ffae2cd
chore: move test to a different PR
sheremet-va Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/vitest/src/integrations/env/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ export function populateGlobal(

const originals = new Map<string | symbol, any>()

const overridenKeys = new Set([...KEYS, ...options.additionalKeys || []])

const overrideObject = new Map<string | symbol, any>()
for (const key of keys) {
const boundFunction
Expand All @@ -60,7 +62,7 @@ export function populateGlobal(
&& !isClassLikeName(key)
&& win[key].bind(win)

if (KEYS.includes(key) && key in global) {
if (overridenKeys.has(key) && key in global) {
originals.set(key, global[key])
}

Expand Down
Loading