fix(cli): use absolute path environment on Windows #8105
Merged
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
2 tasks
github-merge-queue bot
pushed a commit
to lynx-family/lynx-stack
that referenced
this pull request
Jun 6, 2025
## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> Similar to #1007, we normalize the relative path to ensure consistent snapshot generation across Windows, Linux, and macOS. > [!NOTE] > The testing library does not work on Windows now since we are using `environment` with a absolute path. > An error "Cannot find dependency 'vitest-environment-C:\Users\Admin\colin\lynx-stack\packages\react\testing-library\dist\env\vitest.js'" would occur. > > I've submitted a fix at vitest-dev/vitest#8105 <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> issue: #81 ## Checklist <!--- Check and mark with an "x" --> - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required).
hi-ogawa
approved these changes
Jun 6, 2025
github-merge-queue bot
pushed a commit
to lynx-family/lynx-stack
that referenced
this pull request
Jun 6, 2025
## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> Similar to #1007, we normalize the relative path to ensure consistent snapshot generation across Windows, Linux, and macOS. > [!NOTE] > The testing library does not work on Windows now since we are using `environment` with a absolute path. > An error "Cannot find dependency 'vitest-environment-C:\Users\Admin\colin\lynx-stack\packages\react\testing-library\dist\env\vitest.js'" would occur. > > I've submitted a fix at vitest-dev/vitest#8105 <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> issue: #81 ## Checklist <!--- Check and mark with an "x" --> - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required).
github-merge-queue bot
pushed a commit
to lynx-family/lynx-stack
that referenced
this pull request
Jun 6, 2025
## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> Similar to #1007, we normalize the relative path to ensure consistent snapshot generation across Windows, Linux, and macOS. > [!NOTE] > The testing library does not work on Windows now since we are using `environment` with a absolute path. > An error "Cannot find dependency 'vitest-environment-C:\Users\Admin\colin\lynx-stack\packages\react\testing-library\dist\env\vitest.js'" would occur. > > I've submitted a fix at vitest-dev/vitest#8105 <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> issue: #81 ## Checklist <!--- Check and mark with an "x" --> - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required).
sheremet-va
approved these changes
Jun 11, 2025
1 task
This was referenced Jun 29, 2025
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, using absolute path as
environmentwould failed on Windows:Instead of
env[0] === '/', we usepath.isAbsolute(env)instead.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.