fix: apply development|production condition on Vite 6
#7301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hi-ogawa
force-pushed
the
fix-condition-development-production
branch
from
4b3c12f to
68fae01
Compare
hi-ogawa
force-pushed
the
fix-condition-development-production
branch
from
77e7da3 to
b105765
Compare
hi-ogawa
force-pushed
the
fix-condition-development-production
branch
from
68824e9 to
62bb62e
Compare
sheremet-va
previously approved these changes
Jan 21, 2025
|
@hi-ogawa feel free to merge if this is ready |
6 tasks
sheremet-va
approved these changes
Jan 23, 2025
6 tasks
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Jan 23, 2025
##### [v3.0.4](https://github.com/vitest-dev/vitest/releases/tag/v3.0.4) ##### 🐞 Bug Fixes - Filter projects eagerly during config resolution - by [@sheremet-va](https://github.com/sheremet-va) and [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7313 [<samp>(dff44)</samp>](vitest-dev/vitest@dff4406d) - Apply `development - by @hi-ogawa and @sheremet-va [<samp>(produ)</samp>](https://github.com/vitest-dev/vitest/commit/production` condition on Vite 6 ([#7301](vitest-dev/vitest#7301))) - **browser**: Restrict served files from `/__screenshot-error` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7340 [<samp>(ed9ae)</samp>](vitest-dev/vitest@ed9aeba2) - **deps**: Update all non-major dependencies - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7297 [<samp>(38ea8)</samp>](vitest-dev/vitest@38ea8eae) - **runner**: Timeout long sync hook - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7289 [<samp>(c60ee)</samp>](vitest-dev/vitest@c60ee27c) - **typechecking**: Support typechecking parsing with Vite 6 - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7335 [<samp>(bff70)</samp>](vitest-dev/vitest@bff70be9) - **types**: Fix public types - by [@mrginglymus](https://github.com/mrginglymus) and [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7328 [<samp>(ce6af)</samp>](vitest-dev/vitest@ce6af70c) ##### [View changes on GitHub](vitest-dev/vitest@v3.0.3...v3.0.4)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Jan 24, 2025
##### [v3.0.4](https://github.com/vitest-dev/vitest/releases/tag/v3.0.4) ##### 🐞 Bug Fixes - Filter projects eagerly during config resolution - by [@sheremet-va](https://github.com/sheremet-va) and [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7313 [<samp>(dff44)</samp>](vitest-dev/vitest@dff4406d) - Apply `development - by @hi-ogawa and @sheremet-va [<samp>(produ)</samp>](https://github.com/vitest-dev/vitest/commit/production` condition on Vite 6 ([#7301](vitest-dev/vitest#7301))) - **browser**: Restrict served files from `/__screenshot-error` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7340 [<samp>(ed9ae)</samp>](vitest-dev/vitest@ed9aeba2) - **deps**: Update all non-major dependencies - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7297 [<samp>(38ea8)</samp>](vitest-dev/vitest@38ea8eae) - **runner**: Timeout long sync hook - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7289 [<samp>(c60ee)</samp>](vitest-dev/vitest@c60ee27c) - **typechecking**: Support typechecking parsing with Vite 6 - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7335 [<samp>(bff70)</samp>](vitest-dev/vitest@bff70be9) - **types**: Fix public types - by [@mrginglymus](https://github.com/mrginglymus) and [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7328 [<samp>(ce6af)</samp>](vitest-dev/vitest@ce6af70c) ##### [View changes on GitHub](vitest-dev/vitest@v3.0.3...v3.0.4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolve.conditions#70702nd try for #7070. Thanks @thebanjomatic for the initial PR 🙏
As discussed (see #7070 (comment)), Vite 6 now allows excluding
moduleconditions from their resolve API, so we can go with that on Vitest 3 + Vite 6.Our current
conditions: ["node"]would also drop Vite's defaultdevelopment|productioncondition, so we can usedefaultServerConditionsand just filter outmodule.todo
--conditionsPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.