Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't await an empty timeout after every test #7281

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Jan 17, 2025

Description

Fixes #7275

  • reduce the amount of promises created form 4 to 1
  • remove empty setTimeout

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va requested a review from hi-ogawa January 17, 2025 11:28
@vitest-dev vitest-dev deleted a comment from vitest-ecosystem-ci bot Jan 17, 2025
@vitest-ecosystem-ci
Copy link

vitest-ecosystem-ci bot commented Jan 17, 2025

📝 Ran ecosystem CI: Open

suite result
vitest-reporters-large ✅ success

@AriPerkkio
Copy link
Member

📝 Ran ecosystem CI: Open

suite result
vitest-reporters-large ✅ success

In main it's 27s (ran it couple of times). In this PR it's Tests took 17.666018. In 3.0.0-beta.1 it was 16.8s. Looks good!

@sheremet-va sheremet-va merged commit ef1aa89 into vitest-dev:main Jan 17, 2025
13 checks passed
@sheremet-va sheremet-va deleted the fix/regression-duration branch January 17, 2025 14:23
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Jan 17, 2025
##### [v3.0.2](https://github.com/vitest-dev/vitest/releases/tag/v3.0.2)

#####    🐞 Bug Fixes

-   Don't await an empty timeout after every test  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7281 [<samp>(ef1aa)</samp>](vitest-dev/vitest@ef1aa893)
-   **expect**: Fix `expect().resolves/rejects` chain typings  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7273 [<samp>(fa415)</samp>](vitest-dev/vitest@fa415059)

#####     [View changes on GitHub](vitest-dev/vitest@v3.0.1...v3.0.2)
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Jan 17, 2025
##### [v3.0.2](https://github.com/vitest-dev/vitest/releases/tag/v3.0.2)

#####    🐞 Bug Fixes

-   Don't await an empty timeout after every test  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7281 [<samp>(ef1aa)</samp>](vitest-dev/vitest@ef1aa893)
-   **expect**: Fix `expect().resolves/rejects` chain typings  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7273 [<samp>(fa415)</samp>](vitest-dev/vitest@fa415059)

#####     [View changes on GitHub](vitest-dev/vitest@v3.0.1...v3.0.2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Low performance on vitest version 3.0
2 participants