-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(expect)!: pass current equality testers to asymmetric matcher #6825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sheremet-va
merged 6 commits into
vitest-dev:main
from
hi-ogawa:fix-testers-for-asymmetric-matcher
Sep 8, 2025
Merged
fix(expect)!: pass current equality testers to asymmetric matcher #6825
sheremet-va
merged 6 commits into
vitest-dev:main
from
hi-ogawa:fix-testers-for-asymmetric-matcher
Sep 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
hi-ogawa
commented
Jan 17, 2025
|
|
||
| export interface AsymmetricMatcherInterface { | ||
| asymmetricMatch: (other: unknown) => boolean | ||
| asymmetricMatch: (other: unknown, customTesters?: Array<Tester>) => boolean |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: see if we can keep the API same without extending arguments.
Member
|
@hi-ogawa can you resolve conflicts, please? 👀 |
sheremet-va
approved these changes
Sep 8, 2025
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is breaking (making equality stricter in most cases) but this behavior probably makes more sense.
Examples
Following assertions previously passed but now it fails.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.