Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update @antfu/eslint-config v3.8.0 #6751

Merged
merged 9 commits into from
Oct 23, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Oct 21, 2024

Description

New import sorting based on https://github.com/azat-io/eslint-plugin-perfectionist is a huge change, so I split it from renovate PRs #6750
Though the diff is huge, the sorting looks clean, so it's probably fine to adopt this?

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7e105e1
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67171e7100f36600082fe428
😎 Deploy Preview https://deploy-preview-6751--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review October 21, 2024 04:59
docs/guide/mocking.md Outdated Show resolved Hide resolved
Comment on lines 70 to 72
import MyWorker from '../worker?worker'
// worker.test.ts
import '@vitest/web-worker'
import MyWorker from '../worker?worker'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is still fixed after disabling **/*.md. Let me check this further.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a while to figure out weird globbing **/*.md/${GLOB_SRC} 😅 f32bdbb

@sheremet-va sheremet-va merged commit de74785 into vitest-dev:main Oct 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants