Skip to content

fix(browser): correctly mock optimized cjs dependencies #6035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

sheremet-va
Copy link
Member

Description

Fixes #6034

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va marked this pull request as draft July 4, 2024 08:43
@sheremet-va sheremet-va changed the title fisx(browser): remove "v" query when mocking fix(browser): remove "v" query when mocking Jul 4, 2024
@sheremet-va sheremet-va changed the title fix(browser): remove "v" query when mocking fix(browser): remove "v" query when mocking a module Jul 4, 2024
@sheremet-va sheremet-va changed the title fix(browser): remove "v" query when mocking a module fix(browser): correctly mock optimized cjs dependencies Jul 4, 2024
@sheremet-va sheremet-va marked this pull request as ready for review July 4, 2024 09:15
@sheremet-va sheremet-va merged commit 057b4f3 into vitest-dev:main Jul 4, 2024
16 checks passed
@sheremet-va sheremet-va deleted the fix/mock-version branch July 4, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module mock does not work in some cases in browser mode
1 participant