Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: lock node version for worker tests #6001

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Jun 30, 2024

Description

test.each([
{ pool: 'forks', execArgv: ['--hash-seed=1', '--random-seed=1', '--no-opt'] },
{ pool: 'threads', execArgv: ['--inspect-brk'] },
{ pool: 'vmThreads', execArgv: ['--inspect-brk'] },
] as const)('should pass execArgv to { pool: $pool } ', async ({ pool, execArgv }) => {
const root = './fixtures/exec-args-fixtures'
const fileToTest = `${pool}.test.ts`
const vitest = await runVitest({
root,
include: [fileToTest],
pool,
poolOptions: {
[pool]: {
execArgv,
},
},
})
expect(vitest.stdout).toContain(`✓ ${fileToTest}`)
expect(vitest.stderr).toBe('')
})

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va merged commit 910a04b into vitest-dev:main Jun 30, 2024
16 checks passed
@AriPerkkio AriPerkkio deleted the ci/fix-worker-tests branch June 30, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants