Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest): inline chai types instead of using @types/chai #4209

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Oct 2, 2023

Description

Fixes #2118

By the way, this is how Cypress fixes it 😄

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 72be0cd
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/651ab1685bd5b90008cca8bc

Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly they are so short :P

@sheremet-va
Copy link
Member Author

Interestingly they are so short :P

The link in the issue points to chai v2, but we use the latest version which is 2k lines 😄 (mostly documentation)

@sheremet-va sheremet-va changed the title feat: inline chai types instead of using @types/chai fix(vitest): inline chai types instead of using @types/chai Oct 2, 2023
@sheremet-va sheremet-va merged commit 5f4774f into vitest-dev:main Oct 2, 2023
13 of 16 checks passed
@sheremet-va sheremet-va deleted the feat/inline-chai-types branch October 2, 2023 12:26
@kosgdk
Copy link

kosgdk commented Oct 2, 2023

Now not is broken:

image

@sheremet-va
Copy link
Member Author

sheremet-va commented Oct 2, 2023

Now not is broken:

image

If you can open an issue with reproduction, that would be lovely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript types adding unwanted / buggy 'Chai.Assertion' type requirement on should function interface return
3 participants