-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: support using function/class as describe/test name
#3497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sheremet-va
merged 6 commits into
vitest-dev:main
from
fenghan34:feat/describe-test-name
Jun 5, 2023
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
49be42d
feat: support using function as describe/test name
fenghan34 3970374
fix: update lock file
fenghan34 7fc5d58
fix: update lock file
fenghan34 e64be7d
docs: update api types
fenghan34 1252aea
test: move to reporters
fenghan34 91e1962
chore: update lock file
fenghan34 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { describe, expect, test } from 'vitest' | ||
|
|
||
| function foo() {} | ||
| class Bar {} | ||
|
|
||
| describe(foo, () => { | ||
| test(Bar, () => { | ||
| expect(0).toBe(1) | ||
| }) | ||
| }) | ||
|
|
||
| describe(Bar, () => { | ||
| test(foo, () => { | ||
| expect(0).toBe(1) | ||
| }) | ||
| }) | ||
|
|
||
| describe.each([1])(foo, () => { | ||
| test.each([1])(foo, () => { | ||
| expect(0).toBe(1) | ||
| }) | ||
| }) | ||
|
|
||
| describe.each([1])(Bar, () => { | ||
| test.each([1])(Bar, () => { | ||
| expect(0).toBe(1) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "name": "@vitest/test-describe-test-name", | ||
| "private": true, | ||
| "scripts": { | ||
| "test": "vitest run" | ||
| }, | ||
| "devDependencies": { | ||
| "vitest": "workspace:*" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { expect, test } from 'vitest' | ||
| import { resolve } from 'pathe' | ||
| import { runVitest } from '../../test-utils' | ||
|
|
||
| test('should print function name', async () => { | ||
| const filename = resolve('./fixtures/test/example.test.ts') | ||
| const { stderr } = await runVitest({ root: './fixtures' }, [filename]) | ||
|
|
||
| expect(stderr).toBeTruthy() | ||
| expect(stderr).toContain('FAIL test/example.test.ts > foo > Bar') | ||
| expect(stderr).toContain('FAIL test/example.test.ts > Bar > foo') | ||
| expect(stderr).toContain('FAIL test/example.test.ts > foo > foo') | ||
| expect(stderr).toContain('FAIL test/example.test.ts > Bar > Bar') | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import { defineConfig } from 'vitest/config' | ||
|
|
||
| export default defineConfig({ | ||
| test: { | ||
| include: ['test/**/*.test.*'], | ||
| }, | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.