Repository navigation
fix(ui): fix collapse/expand suite with file name search #11260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+28
−2
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0e6ac18
fix(ui): expand file matches during search
hi-ogawa c7b0d34
docs(ui): clarify explorer state
hi-ogawa 52c14f3
docs(ui): explain expanded entry collection
hi-ogawa 197c5e7
docs(ui): clarify expanded entry rebuild
hi-ogawa bb02b38
docs(ui): describe expanded entry emission
hi-ogawa 1351d11
docs(ui): note expanded entry refactor
hi-ogawa f2587f3
docs(ui): explain filter traversal state
hi-ogawa daef937
docs(ui): move expanded entry todo
hi-ogawa 065a112
docs(ui): note filter state ownership
hi-ogawa 7d46332
docs(ui): use jsdoc for explorer state
hi-ogawa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -501,6 +501,10 @@ async function testError(page: Page) { | |
| async function testSuiteReport(page: Page) { | ||
| const report = page.getByTestId('report') | ||
|
|
||
| await expect(getExplorerItem(page, 'sample.test.ts')).toBeVisible() | ||
| await page.getByPlaceholder('Search...').fill('suite-report') | ||
| await expect(getExplorerItem(page, 'sample.test.ts')).toHaveCount(0) | ||
|
Comment on lines
+504
to
+506
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This sets up search to stabilize the tree and later we have assertion of suite collapse/expand: // test that the suite can be collapsed and expanded
await expect(getExplorerItem(page, 'successful child')).toBeVisible()
await successfulSuite.getByRole('button', { name: 'Collapse successful suite', exact: true }).click()
await expect(getExplorerItem(page, 'successful child')).not.toBeVisible()
await successfulSuite.getByRole('button', { name: 'Expand successful suite', exact: true }).click()
await expect(getExplorerItem(page, 'successful child')).toBeVisible() |
||
|
|
||
| await getExplorerItem(page, 'suite-report.test.ts').click() | ||
| await expect(report).toContainText('before-all-marker') | ||
| await expect(report).toContainText('direct-child-marker') | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix is the three liners.