-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(coverage): istanbul to support instrumenter option
#10119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sheremet-va
merged 12 commits into
vitest-dev:main
from
BartWaardenburg:feat/custom-instrumenter
Apr 20, 2026
+202
−22
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
602a232
feat(coverage-istanbul): support custom instrumenter option
BartWaardenburg b1211c0
fix: use function property syntax for CoverageInstrumenter interface
BartWaardenburg 1b1d924
feat(coverage-istanbul): add tests and public export for custom instr…
BartWaardenburg 2d0f136
feat(coverage-istanbul): pass coverageVariable to custom instrumenter
BartWaardenburg 2d83b31
fix: add parens for arrow with block body (style/arrow-parens)
BartWaardenburg be390ca
fix(coverage): align custom instrumenter contract
BartWaardenburg a4bbd67
fix(test): type mock instrumenter callback
BartWaardenburg 2d8a95a
docs(coverage): document istanbul `instrumenter` option
BartWaardenburg 3f2aace
Update docs/config/coverage.md
AriPerkkio 57bae78
Apply suggestions from code review
AriPerkkio d11ff07
docs: fix missing jsdoc
AriPerkkio 8fbfcb0
docs: never using github batch commits again
AriPerkkio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
test/coverage-test/test/custom-instrumenter.istanbul.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { expect, vi } from 'vitest' | ||
| import { normalizeURL, runVitest, test } from '../utils' | ||
|
|
||
| test('custom instrumenter receives correct options', async () => { | ||
| const instrumenter = vi.fn().mockReturnValue({ | ||
| instrumentSync: (code: string) => code, | ||
| lastSourceMap: () => ({}), | ||
| lastFileCoverage: () => ({ | ||
| path: 'test.ts', | ||
| statementMap: {}, | ||
| fnMap: {}, | ||
| branchMap: {}, | ||
| s: {}, | ||
| f: {}, | ||
| b: {}, | ||
| }), | ||
| }) | ||
|
|
||
| await runVitest({ | ||
| include: [normalizeURL(import.meta.url)], | ||
| coverage: { | ||
| reporter: 'json', | ||
| ignoreClassMethods: ['test-method'], | ||
| instrumenter, | ||
| }, | ||
| }, { throwOnError: false }) | ||
|
|
||
| expect(instrumenter).toHaveBeenCalledWith({ | ||
| coverageVariable: '__VITEST_COVERAGE__', | ||
| coverageGlobalScope: 'globalThis', | ||
| coverageGlobalScopeFunc: false, | ||
| ignoreClassMethods: ['test-method'], | ||
| }) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.