chore: make any array indexable in toContain

vitest-dev · Nov 15, 2023 · eff9c91 · eff9c91
1 parent 255ad01
commit eff9c91
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/packages/expect/src/jest-expect.ts b/packages/expect/src/jest-expect.ts
@@ -164,7 +164,7 @@ export const JestChaiExpect: ChaiPlugin = (chai, utils) => {
       return this.match(expected)
   })
   def('toContain', function (item) {
-    const actual = this._obj
+    const actual = this._obj as Iterable<unknown> | string | Node | DOMTokenList
 
     if (typeof Node !== 'undefined' && actual instanceof Node) {
       if (!(item instanceof Node))
@@ -191,7 +191,9 @@ export const JestChaiExpect: ChaiPlugin = (chai, utils) => {
         actual.value,
       )
     }
-
+    // make "actual" indexable to have compatibility with jest
+    if (actual != null && typeof actual !== 'string')
+      utils.flag(this, 'object', Array.from(actual as Iterable<unknown>))
     return this.contain(item)
   })
   def('toContainEqual', function (expected) {

diff --git a/test/core/test/environments/jsdom.spec.ts b/test/core/test/environments/jsdom.spec.ts
@@ -34,6 +34,17 @@ test('toContain correctly handles DOM nodes', () => {
   const external = document.createElement('div')
   wrapper.appendChild(child)
 
+  const parent = document.createElement('div')
+  parent.appendChild(wrapper)
+  parent.appendChild(external)
+
+  document.body.appendChild(parent)
+  const divs = document.querySelectorAll('div')
+
+  expect(divs).toContain(wrapper)
+  expect(divs).toContain(parent)
+  expect(divs).toContain(external)
+
   expect(wrapper).toContain(child)
   expect(wrapper).not.toContain(external)