fix(expect): Object.freeze breaks toEqual (#4303)

vitest-dev · Oct 16, 2023 · a4501d6 · a4501d6
1 parent a25f601
commit a4501d6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/utils/src/helpers.ts b/packages/utils/src/helpers.ts
@@ -97,7 +97,7 @@ export function clone<T>(
   if (Array.isArray(val)) {
     out = Array((k = val.length))
     seen.set(val, out)
-    while (k--) out[k] = clone(val[k], seen)
+    while (k--) out[k] = clone(val[k], seen, options)
     return out as any
   }
 
@@ -110,7 +110,7 @@ export function clone<T>(
       const descriptor = Object.getOwnPropertyDescriptor(val, k)
       if (!descriptor)
         continue
-      const cloned = clone((val as any)[k], seen)
+      const cloned = clone((val as any)[k], seen, options)
       if ('get' in descriptor) {
         Object.defineProperty(out, k, {
           ...descriptor,

diff --git a/test/core/test/jest-expect.test.ts b/test/core/test/jest-expect.test.ts
@@ -303,6 +303,13 @@ describe('jest-expect', () => {
     expect(() => {
       expect(complex).toHaveProperty('a-b', false)
     }).toThrowErrorMatchingInlineSnapshot('"expected { \'0\': \'zero\', foo: 1, …(4) } to have property "a-b" with value false"')
+
+    expect(() => {
+      const x = { a: { b: { c: 1 } } }
+      const y = { a: { b: { c: 2 } } }
+      Object.freeze(x.a)
+      expect(x).toEqual(y)
+    }).toThrowErrorMatchingInlineSnapshot(`"expected { a: { b: { c: 1 } } } to deeply equal { a: { b: { c: 2 } } }"`)
   })
 
   it('assertions', () => {