Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: avoid nullish config type #629

Merged
merged 1 commit into from
Jan 1, 2025
Merged

chore: avoid nullish config type #629

merged 1 commit into from
Jan 1, 2025

Conversation

ST-DDT
Copy link
Contributor

@ST-DDT ST-DDT commented Jan 1, 2025

This PR changes the VitestPlugin type to use a non nullish configs value, as it makes the type easier to use in type aware configs.

grafik

It probably broke as part of this commit:

Ref:

veritem
veritem approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@veritem veritem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@veritem veritem merged commit 997df59 into vitest-dev:main Jan 1, 2025
@ST-DDT ST-DDT deleted the types/plugin-configs branch January 1, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veritem veritem veritem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ST-DDT @veritem