Skip to content

Documentation for temporary tables#702

Merged
systay merged 13 commits intoprodfrom
hg-temp-tables
Feb 17, 2021
Merged

Documentation for temporary tables#702
systay merged 13 commits intoprodfrom
hg-temp-tables

Conversation

@harshit-gangal
Copy link
Copy Markdown
Member

@harshit-gangal harshit-gangal commented Feb 9, 2021

Added documentation around temporary table support in Vitess

@harshit-gangal
documentation for temporary tables
dde6a14 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal requested a review from systay February 9, 2021 15:42
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 9, 2021

Deploy preview for vitess ready!

Built with commit d624b7b

https://deploy-preview-702--vitess.netlify.app

@harshit-gangal harshit-gangal mentioned this pull request Feb 9, 2021
Merged
2 tasks
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 9, 2021 •
edited
Loading

Deploy preview for vitess ready!

Built with commit 73605f1

https://deploy-preview-702--vitess.netlify.app

deepthi
deepthi reviewed Feb 9, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar and phrasing suggestions.

@harshit-gangal
addressed review comments
7a0cfd5 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
shlomi-noach
shlomi-noach reviewed Feb 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please clarify in the docs: is there a scenario where this reserved connection is finally returned to the pool, and someone else gets access to that connection, resulting in that someone able to read the temporary table?

@harshit-gangal
Copy link
Copy Markdown
Member Author

harshit-gangal commented Feb 11, 2021

I will link reserved connection to its write up

@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Feb 11, 2021

Can you please clarify in the docs: is there a scenario where this reserved connection is finally returned to the pool, and someone else gets access to that connection, resulting in that someone able to read the temporary t

I will link reserved connection to its write up

Pre-approving. You can merge after addressing @shlomi-noach's concern.

@systay
more info about reserved connections
882805f 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay requested a review from shlomi-noach February 17, 2021 06:25
systay added 10 commits February 17, 2021 07:28
@systay
shutting down reserved connections
1b7fcc8 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
shutting down reserved connections
2e0f702 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
shutting down reserved connections
d1be3d6 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
info about advisory locking
c16dccd 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
spelling
384f85f 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
temp tables
6f8f08d 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
typo
a91f20a 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
links
01da73e 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
links
5a04610 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
links
73605f1 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit 545f130 into prod Feb 17, 2021
@systay systay deleted the hg-temp-tables branch February 17, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepthi deepthi deepthi approved these changes

@systay systay Awaiting requested review from systay

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harshit-gangal @deepthi @shlomi-noach @systay