Doc updates; tablet throttler: check-self#686
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
|
Deploy preview for vitess ready! Built with commit d72ff6a |
|
Relevant preview link: https://deploy-preview-686--vitess.netlify.app/docs/reference/features/tablet-throttler/ |
|
Let us hold this until 9.0 is out? |
Sure! |
|
This should be merged now, as the code has been merged. |
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
A couple of suggestions. You can go ahead and merge after addressing them.
|
|
||
| ### Self health | ||
|
|
||
| Each tablet to its own, runs a local health check against its backend database, again in the form of evaluating replication lag from `_vt.heartbeat`. Intervals are identical to the cluster health interval illustrated above. |
There was a problem hiding this comment.
| Each tablet to its own, runs a local health check against its backend database, again in the form of evaluating replication lag from `_vt.heartbeat`. Intervals are identical to the cluster health interval illustrated above. | |
| Each tablet runs a local health check against its backend database, again in the form of evaluating replication lag from `_vt.heartbeat`. Intervals are identical to the cluster health interval illustrated above. |
|
|
||
| - The throttler is currently disabled by default. Use the `vttablet` option `-enable-lag-throttler` to enable the throttler. | ||
| When the throttler is disabled, it still serves `/throttler/check` API and responds with `HTTP 200 OK` to all requests. | ||
| - The throttler is currently **disabled** by default. Use the `vttablet` option `-enable-lag-throttler` to enable the throttler. |
There was a problem hiding this comment.
Can we keep the flags consistent and always use underscores? we have enable-lag-throttler but throttle_threshold.
There was a problem hiding this comment.
Right! So this is all over the place, we have dashes and underscored spread across many flags. I'm just wondering how do we go about this with existing flags? Let me see if there's something in golang that treats both as the same, as it it's an uppercase/lowercase thing.
There was a problem hiding this comment.
Noting that this is not a documentation issue -- the flag is named -enable-lag-throttler and we should normalize the flag name in code.
There was a problem hiding this comment.
A bit of digging brought up this. So what I'll do is for some variables support both dash-based and underscore-based names.
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
2 participants
Documenting the changes in vitessio/vitess#7319: a new API endpoint
/throttler/check-selfand what it means.