Skip to content

monthly broken link fixing#657

Merged
rohit-nayak-ps merged 2 commits intoprodfrom
mp-broken-links
Jan 7, 2021
Merged

monthly broken link fixing#657
rohit-nayak-ps merged 2 commits intoprodfrom
mp-broken-links

Conversation

@hallaroo
Copy link
Copy Markdown
Member

@hallaroo hallaroo commented Jan 5, 2021

Monthly check and fix for broken links on vitess.io/docs

Signed-off-by: hallaroo <marla@planetscale.com>
@hallaroo hallaroo requested review from askdba and deepthi January 5, 2021 16:30
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 5, 2021

Deploy preview for vitess ready!

Built with commit 643e993

https://deploy-preview-657--vitess.netlify.app

@hallaroo hallaroo self-assigned this Jan 5, 2021
Copy link
Copy Markdown
Contributor

@askdba askdba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hallaroo
Copy link
Copy Markdown
Member Author

hallaroo commented Jan 5, 2021

Good point - I have no idea where those images went so I think the best option will be to simply remove them. I'll get that update made a re-request a review.

Signed-off-by: hallaroo <marla@planetscale.com>
@hallaroo hallaroo requested a review from askdba January 5, 2021 20:13
Copy link
Copy Markdown
Member

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit 5d0a9f0 into prod Jan 7, 2021
@rohit-nayak-ps rohit-nayak-ps deleted the mp-broken-links branch January 7, 2021 14:25
@askdba
Copy link
Copy Markdown
Contributor

askdba commented Jan 7, 2021

@rohit-nayak-ps beat me to it. For images probably they were external links. Thanks

@hallaroo
Copy link
Copy Markdown
Member Author

hallaroo commented Jan 7, 2021

Thank you both!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants