Conversation
shlomi-noach
force-pushed
the
docker-local
branch
from
09c3acf to
744c06a
Compare
Contributor
Author
|
|
Contributor
Author
|
Change tested on local |
morgo
reviewed
Jun 30, 2020
| @@ -0,0 +1,92 @@ | |||
| --- | |||
| title: Local setup via docker | |||
Contributor
There was a problem hiding this comment.
Can we call it "Local Install via Docker"? Then it will appear below "Local Install" and look consistent.
Otherwise LGTM
Contributor
Author
There was a problem hiding this comment.
Can we call it "Local Install via Docker"?
Done!
Contributor
|
Now getting a DCO error from the last two commits :( I'll merge when you fix :-) |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
force-pushed
the
docker-local
branch
from
261c271 to
c287ef8
Compare
Contributor
Author
|
am much confused about DCO. Asking internally for guidance on configuration. |
morgo
approved these changes
Jun 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR documents the changes merged in vitessio/vitess#6393, by adding a local-docker page the illustrates how to uild and run the docker-local image.