Skip to content

Fix macOS expected output/results #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morgo merged 3 commits into from
Nov 6, 2019
Merged

Fix macOS expected output/results #350

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
915b959
Fix macOS expected output/results
morgo Nov 5, 2019
2d1f34c
Incorporate PR feedback
morgo Nov 5, 2019
6240c65
oops.. wrong branch
morgo Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions content/en/docs/contributing/build-on-macos.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,24 @@ Run `bootstrap.sh` script to download additional dependencies. If your machine r
BUILD_PYTHON=0 BUILD_JAVA=0 ./bootstrap.sh
```

This may result in a warning about `$GOROOT` and an unsupported architecture. It is safe to ignore these errors for now:

This should result in output similar to the following:
```
morgans-mini:vitess morgo$ BUILD_PYTHON=0 BUILD_JAVA=0 ./bootstrap.sh
WARNING: $GOROOT may not be compatible with the used go binary
Please make sure 'go' comes from $GOROOT/bin
go_env: /usr/local/Cellar/go/1.12.6/libexec
go_bin: /usr/local/bin/go
creating git hooks
installing protoc 3.6.1
ERROR: unsupported architecture
--2019-11-05 14:44:32-- https://github.com/protocolbuffers/protobuf/releases/download/v3.6.1/protoc-3.6.1-osx-x86_64.zip
Resolving github.com (github.com)... 140.82.114.4
Connecting to github.com (github.com)|140.82.114.4|:443... connected.
HTTP request sent, awaiting response... 302 Found
...
...
...
2019-11-05 14:44:39 (20.1 MB/s) - ‘consul_1.4.0_darwin_amd64.zip’ saved [34526567/34526567]

Archive: consul_1.4.0_darwin_amd64.zip
inflating: consul

bootstrap finished - run 'source dev.env' or 'source build.env' in your shell before building.
```

Build Vitess:
Expand Down