Consistently name the topology service#327
Merged
morgo merged 5 commits intovitessio:prodfrom Nov 5, 2019
Merged
Conversation
Not lock server/service Not topo server/service Not topology server (except in 1 case when refering to specific instances) Signed-off-by: Morgan Tocker <tocker@gmail.com>
deepthi
reviewed
Oct 31, 2019
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
I have a few suggestions. Will re-review once the TER section is re-written.
| topology records (but they won’t lose any MySQL data). | ||
|
|
||
| If the Global Topology Server dies and is not recoverable, this is more of a | ||
| If the Global Topology Service dies and is not recoverable, this is more of a |
Collaborator
There was a problem hiding this comment.
Maybe add something here about backing up topology data?
Contributor
Author
There was a problem hiding this comment.
Address PR Feedback Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
deepthi
approved these changes
Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #318
Fixes #340
Not lock server/service
Not topo server/service
Not topology server (except in 1 case when referring to specific instances)
Also moves topology service to reference, and fixes up production planning guide.
Signed-off-by: Morgan Tocker tocker@gmail.com