Skip to content

Remove MYSQL_FLAVOR requirement #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
morgo wants to merge 3 commits into from
Closed

Remove MYSQL_FLAVOR requirement #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76377dc
Remove MYSQL_FLAVOR requirement
morgo Aug 8, 2019
2b59628
Incorporate reviewer feedback
morgo Aug 13, 2019
c6e3cba
Merge remote-tracking branch 'upstream/prod' into morgo-remove-mysql-…
morgo Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions content/en/docs/contributing/build-from-source.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ In addition, Vitess requires the following software and libraries:
# Apt based
sudo apt-get install mysql-server
# Yum based
sudo yum install mysql-server
sudo yum localinstall https://dev.mysql.com/get/mysql57-community-release-el7-9.noarch.rpm
sudo yum install mysql-community-server
```

_Vitess supports MySQL 5.6+ and MariaDB 10.0+. We recommend MySQL 5.7 if your installation method provides a choice._
Expand Down Expand Up @@ -121,13 +122,7 @@ _Vitess supports MySQL 5.6+ and MariaDB 10.0+. We recommend MySQL 5.7 if your in
cd src/vitess.io/vitess
```

2. Set the `MYSQL_FLAVOR`:
```sh
# It is recommended to use MySQL56 even for MySQL 5.7 and 8.0. For MariaDB you can use MariaDB:
export MYSQL_FLAVOR=MySQL56
```

3. If your selected database installed in a location other than `/usr/bin`, set the `VT_MYSQL_ROOT` variable to the root directory of your MySQL installation:
2. If your selected database installed in a location other than `/usr/bin`, set the `VT_MYSQL_ROOT` variable to the root directory of your MySQL installation:

```sh
# For generic tarballs on Linux
Expand All @@ -139,9 +134,9 @@ export MYSQL_FLAVOR=MySQL56

Note that the command indicates that the `mysql` executable should be found at `/usr/local/opt/mysql@5.7/bin/mysql`.

4. Run `mysqld --version` and confirm that you are running MySQL 5.7.
3. Run `mysqld --version` and confirm that you are running MySQL 5.7.

5. Build Vitess using the commands below. Note that the `bootstrap.sh` script needs to download some dependencies. If your machine requires a proxy to access the Internet, you will need to set the usual environment variables (e.g. `http_proxy`, `https_proxy`, `no_proxy`).
4. Build Vitess using the commands below. Note that the `bootstrap.sh` script needs to download some dependencies. If your machine requires a proxy to access the Internet, you will need to set the usual environment variables (e.g. `http_proxy`, `https_proxy`, `no_proxy`).

Run the boostrap.sh script:

Expand Down
4 changes: 2 additions & 2 deletions content/en/docs/get-started/local.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ PlanetScale provides [weekly builds](https://github.com/planetscale/vitess-relea
# Apt based
sudo apt-get install mysql-server
# Yum based
sudo yum install mysql-server
sudo yum localinstall https://dev.mysql.com/get/mysql57-community-release-el7-9.noarch.rpm
sudo yum install mysql-community-server
```

_Vitess supports MySQL 5.6+ and MariaDB 10.0+. We recommend MySQL 5.7 if your installation method provides a choice._
Expand All @@ -42,7 +43,6 @@ Add the following to your `.bashrc` file. Make sure to replace `/path/to/extract
```bash
export VTROOT=/path/to/extracted-tarball
export VTTOP=$VTROOT
export MYSQL_FLAVOR=MySQL56
export VTDATAROOT=${HOME}/vtdataroot
export PATH=${VTROOT}/bin:${PATH}
```
Expand Down
1 change: 0 additions & 1 deletion content/en/docs/get-started/vagrant.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ The `client.py` file is a simple sample application that connects to `vtgate` an
```sh
export VTROOT=/vagrant
export VTDATAROOT=/tmp/vtdata-dev
export MYSQL_FLAVOR=MySQL56
cd "$VITESS_WORKSPACE"/examples/local
./client.sh
### example output:
Expand Down