Skip to content

Remove local-docker-guide from v21#1781

Merged
deepthi merged 1 commit intovitessio:prodfrom
kirtanchandak:remove-local-docker/kirtan
Jul 8, 2024
Merged

Remove local-docker-guide from v21#1781
deepthi merged 1 commit intovitessio:prodfrom
kirtanchandak:remove-local-docker/kirtan

Conversation

@kirtanchandak
Copy link
Collaborator

  • removed local docker guide from v21

Signed-off-by: kirtanchandak <themarketingkirtan@gmail.com>
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's debatable whether we want to do this on all supported docs version (18, 19, 20, 21) or just 21. I don't have strong opinions, but if we decide to do so, we shoudl backport vitessio/vitess#16335 to the corresponding branches.

@kirtanchandak
Copy link
Collaborator Author

LGTM, it's debatable whether we want to do this on all supported docs version (18, 19, 20, 21) or just 21. I don't have strong opinions, but if we decide to do so, we shoudl backport vitessio/vitess#16335 to the corresponding branches.

@deepthi what should we do?

@deepthi
Copy link
Collaborator

deepthi commented Jul 8, 2024

LGTM, it's debatable whether we want to do this on all supported docs version (18, 19, 20, 21) or just 21. I don't have strong opinions, but if we decide to do so, we shoudl backport vitessio/vitess#16335 to the corresponding branches.

Let's do this on just v21 for now. If at all, we may do it on v20 as well, but no need to do any older releases. And even if we decide to change the docs on older releases, there's no need to backport the Makefile change, it doesn't hurt anything to leave that there if there is no reference to it in the docs.

@netlify
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit a858800
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/668648f99a490c000868ef99
😎 Deploy Preview https://deploy-preview-1781--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@deepthi deepthi merged commit e780bae into vitessio:prod Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants