Docs: Unconfigured heartbeat still serves heartbeat event at throttler requests#1762
Merged
shlomi-noach merged 7 commits intoprodfrom Jul 8, 2024
Merged
Docs: Unconfigured heartbeat still serves heartbeat event at throttler requests#1762shlomi-noach merged 7 commits intoprodfrom
shlomi-noach merged 7 commits intoprodfrom
Conversation
…r requests Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
5 tasks
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
The code change did not make it into |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Author
|
Ready to review. This change also removes sections of the code that relate to EOL versions (v17 and below). |
mattlord
approved these changes
Jul 8, 2024
Co-authored-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documenting the changes in vitessio/vitess#16014.
See also: vitessio/vitess#15303