Conversation
|
/cc @vitessio/query-serving |
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@davidpiegza thank you for the contribution. Do you mind fixing the DCO by amending your commit with a |
Signed-off-by: David Piegza <davidpiegza@github.com>
davidpiegza
force-pushed
the
add-docs-for-vschema-ddl
branch
from
bcf0ffa to
282d3c0
Compare
Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: David Piegza <697113+davidpiegza@users.noreply.github.com>
Signed-off-by: David Piegza <davidpiegza@github.com>
|
@deepthi I applied the suggestions and referenced the new page in a vtgate doc. If this looks good I can add the documentation to the other versions. |
frouioui
left a comment
frouioui
left a comment
There was a problem hiding this comment.
Unless we backport vitessio/vitess#13882 to release-17.0, let's move all of this documentation to content/en/docs/18.0/... please
Signed-off-by: David Piegza <davidpiegza@github.com>
davidpiegza
force-pushed
the
add-docs-for-vschema-ddl
branch
from
d939ae8 to
115f040
Compare
|
@frouioui @deepthi I moved it to v18.0 docs and also decided with @arthurschreiber to change the page to actually describe each query on it's own (and not use the examples from the vitess repo). Here is a readable version. |
|
Waiting for vitessio/vitess#13882 to be merged before merging this PR. |
frouioui
added
the
do-not-merge
frouioui
removed
the
do-not-merge
5 participants
Add docs for VSchema DDL.
A new page has been added to
User Guides -> VSchema and Query Serving -> VSchema DDL. The content is taken from https://github.com/vitessio/vitess/blob/6d26dad29110566ded746f5013bd1115d9f200b4/examples/demo/vschema_ddls.sql.Please note, this is a first version and probably not complete. I added it for V17.0 only and would copy it to other versions after first reviews.