Correct env.sh path in v16+ local examples docs#1569
Merged
Conversation
Signed-off-by: Matt Lord <mattalord@gmail.com>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
deepthi
reviewed
Aug 28, 2023
|
|
||
| ```bash | ||
| source ./env.sh | ||
| source ../common/env.sh |
Collaborator
There was a problem hiding this comment.
This was moved to common only in v17, so the v16 and v15 docs should not have any such change.
Collaborator
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
Turns out the original PR was back ported to v16.
Member
Author
There was a problem hiding this comment.
Yes, here's the backport PR (bot failed): vitessio/vitess#12278
deepthi
approved these changes
Aug 28, 2023
Signed-off-by: Matt Lord <mattalord@gmail.com>
Contributor
I like this, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We also simplify and unify the prompt usage in the commands:
$as the static promptFixes: #1523