Update throttler config docs for v17#1489
Merged
shlomi-noach merged 2 commits intoprodfrom Jun 6, 2023
Merged
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
4 tasks
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mattlord
approved these changes
Jun 5, 2023
Member
mattlord
left a comment
mattlord
left a comment
There was a problem hiding this comment.
Just a couple of nits. Thanks!
| ### v17 and forward | ||
|
|
||
| In `v16`, throttler configuration is found in the [local topology server](../../../concepts/topology-service/). There is one configuration per keyspace. All shards and all tablets in all cells have the same throttler configuration: they are all enabled or disabled, and all share the same threshold or custom query. Since configuration is stored outside the tablet, it survives tablet restarts. | ||
| In `v17`, and as of `v16`, throttler configuration is found in the [local topology server](../../../concepts/topology-service/). There is one configuration per keyspace. All shards and all tablets in all cells have the same throttler configuration: they are all enabled or disabled, and all share the same threshold or custom query. Since configuration is stored outside the tablet, it survives tablet restarts. |
Member
There was a problem hiding this comment.
I'd just say v17 here since it was experimental in v16 and the section title is v17 an forward.
|
|
||
|
|
||
| ### v15 and before | ||
| ### v16, v15 and before |
Member
There was a problem hiding this comment.
We can just say v16 and before.
Member
|
Unrelated to the PR, but since we're editing the page, we should also turn the single dashes to double dashes in the code snippet at the end of this section: https://deploy-preview-1489--vitess.netlify.app/docs/17.0/reference/features/tablet-throttler/#v16-v15-and-before |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Author
|
fixed single->double dashes |
4 tasks
ajm188
pushed a commit
that referenced
this pull request
Jun 26, 2023
* Update throttler config docs for v17 Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * fixed per reivew Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> --------- Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating docs per changes in vitessio/vitess#13130:
throttler-config-via-toponow defaultstrue