-
Notifications
You must be signed in to change notification settings - Fork 234
blog: security audit #1486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
blog: security audit #1486
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
175b1ad
blog: security audit
deepthi 328a5c3
add quotes
deepthi e328e8c
fix publication date and slug
deepthi cc9a1e4
review feedback, fix typo
deepthi 243586c
rewrite SLSA line, address review feedback
deepthi 9114b41
correct number of fuzzers and pdf location
deepthi cbf9cb8
replace 2 with two
deepthi 643604b
add pdf file
deepthi ed1bb4e
revised doc
deepthi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| --- | ||
| author: 'Deepthi Sigireddi' | ||
| date: 2023-05-31 | ||
| slug: '2023-05-31-vitess-security-audit' | ||
| tags: ['security','Vitess','MySQL'] | ||
| title: 'Vitess Security Audit Results' | ||
| description: "Third-party security audit of Vitess completed" | ||
| --- | ||
|
|
||
| The Vitess Maintainer team is pleased to announce the results of a recent third-party security audit of the Vitess code base. | ||
|
|
||
| Vitess had previously been audited in 2019. Given the amount of time that has passed, and the magnitude of change during that time, the maintainer team decided to request a fresh audit. | ||
| Starting in March 2023, an independent team from AdaLogics performed a full security audit of Vitess with special emphasis on VTAdmin, which is a relatively new addition to Vitess. | ||
|
|
||
| ## Scope | ||
| The goals of the audit were to: | ||
|
|
||
| * Produce a formal threat model of VTAdmin. | ||
| * Perform a manual audit of the VTAdmin code following the threat model. | ||
| * Align Vitess’s fuzzing suite with the threats identified by the maintainers. | ||
| * Perform a manual audit of the remaining Vitess code base. | ||
| * Conduct a Supply Chain Levels for Software Artifacts (SLSA) review of Vitess. | ||
|
|
||
| ## Outcomes | ||
| * No Critical issues were found during the audit. | ||
| * A number of Moderate/Low/Informational issues were reported. | ||
| * The project published 2 Moderate Severity CVEs and patch releases with associated fixes for them. | ||
| * All the reported issues that are under our control have either been fixed, or have a plan in place to be fixed before the end of the year. | ||
| * We ended up deleting some unused code as a result of the audit, which is always a good thing. | ||
| * AdaLogics contributed 3 additional fuzzers to the fuzzing test suite for Vitess. | ||
| * Vitess is not SLSA-compliant, because we do not yet generate provenance for our builds. | ||
|
|
||
| We are grateful to the [Cloud Native Computing Foundation](https://cncf.io) for sponsoring this audit, and to [OSTIF](https://ostif.org) and [AdaLogics](https://adalogics.com) for carrying it through. | ||
| Special thanks are due to Andrew Mason and Dirkjan Bussink for doing most of the remediation work, and to Adam Korczynski and David Korczyzski of ADA logics for conducting the audit. | ||
|
deepthi marked this conversation as resolved.
Outdated
|
||
|
|
||
| You can read the full audit report [here](../../files/VIT-03-report.pdf). | ||
|
deepthi marked this conversation as resolved.
Outdated
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.