Add vtgate vstreams created & lag metrics#1473
Merged
mattlord merged 2 commits intovitessio:prodfrom May 19, 2023
Merged
Conversation
twthorn
force-pushed
the
vstream-created-and-lag-metrics-for-vtgate
branch
from
61633b6 to
c8ad9ea
Compare
4 tasks
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mattlord
reviewed
May 18, 2023
Member
mattlord
left a comment
mattlord
left a comment
There was a problem hiding this comment.
Looks good! I only had two very minor comments/requests.
| "VStreamersEndedWithErrors": 0, | ||
| ``` | ||
|
|
||
| ## Gateway Metrics |
Member
There was a problem hiding this comment.
Better to say vtgate metrics as there's no ambiguity there.
| ``` | ||
|
|
||
| ## Monitoring | ||
| Vitess gateways publish vstream metrics listed [here](../metrics/#gateway-metrics). |
Member
There was a problem hiding this comment.
I'd also just say VTGates publish here...
Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
twthorn
force-pushed
the
vstream-created-and-lag-metrics-for-vtgate
branch
from
50cf666 to
e2becb3
Compare
mattlord
approved these changes
May 19, 2023
ajm188
pushed a commit
that referenced
this pull request
Jun 26, 2023
* Add vtgate vstreams created & lag metrics Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> * Clarify naming by changing from gateway to vtgate Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> --------- Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs for vitessio/vitess#13098
Fixes vitessio/vitess#13099