Conversation
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ajm188
previously requested changes
May 22, 2023
Contributor
ajm188
left a comment
ajm188
left a comment
There was a problem hiding this comment.
right change, just need to make it in a different spot (and fix it everywhere!)
| Updates the topology record for the tablet's shard to acknowledge that an external tool made this tablet the primary. | ||
|
|
||
| See the Reparenting guide for more information: https://vitess.io/docs/user-guides/reparenting/#external-reparenting. | ||
| See the Reparenting guide for more information: https://vitess.io/docs/user-guides/configuration-advanced/reparenting/#external-reparenting. |
Contributor
There was a problem hiding this comment.
This is autogenerated from the code (https://github.com/vitessio/vitess/blob/main/go/cmd/vtctldclient/command/reparents.go#L291-L293)
Can you fix it there, then run (in this repo) make vtctldclient-docs?
Collaborator
|
@ajm188 can you take care of this? |
2 tasks
Contributor
Member
Author
|
Thank you! And apologies for not responding sooner! This was on my get to this eventually list so thank you again for dealing with it. |
Contributor
|
oh no i rebased when i meant to merge 🙈 |
ajm188
force-pushed
the
mp-link
branch
2 times, most recently
from
f66b78d to
b7a1066
Compare
Author: hallaroo <marla@planetscale.com> Co-authored-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
deepthi
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing one link that 404's