Skip to content

content/en/docs/18.0: rework vtbackup DurationByPhase into binary valued Phase#1452

Merged
shlomi-noach merged 1 commit intoprodfrom
maxeng-rework-vtb-phase-stats
Aug 2, 2023
Merged

content/en/docs/18.0: rework vtbackup DurationByPhase into binary valued Phase#1452
shlomi-noach merged 1 commit intoprodfrom
maxeng-rework-vtb-phase-stats

Conversation

@maxenglander
Copy link
Collaborator

@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit f3769a3
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/64920c3b40151a00087a9be3
😎 Deploy Preview https://deploy-preview-1452--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@maxenglander maxenglander marked this pull request as ready for review April 26, 2023 12:21
Copy link
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll wait to merge this until the linked code PR is merged.

Copy link
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxenglander since this isn't going into v17, can you move the changes to v18 of the docs?

…ued Phase

Signed-off-by: Max Englander <max@planetscale.com>
@maxenglander maxenglander force-pushed the maxeng-rework-vtb-phase-stats branch from 9e44842 to f3769a3 Compare June 20, 2023 20:29
@maxenglander maxenglander changed the title content/en/docs/17.0: rework vtbackup DurationByPhase into binary valued Phase content/en/docs/18.0: rework vtbackup DurationByPhase into binary valued Phase Jun 20, 2023
@maxenglander
Copy link
Collaborator Author

Thanks @deepthi I've updated this PR as well as the changelog in vitessio/vitess#12973

@maxenglander maxenglander requested a review from deepthi June 20, 2023 20:49
@shlomi-noach shlomi-noach dismissed deepthi’s stale review August 2, 2023 06:07

requested changes were made

@shlomi-noach
Copy link
Contributor

Requested changes were made. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants