Skip to content

vttablet program docs: add --tx-throttler-tablet-types flag#1368

Merged
shlomi-noach merged 9 commits intovitessio:prodfrom
timvaillancourt:vttablet-tx-throttler-tablet-types-flag
May 21, 2023
Merged

vttablet program docs: add --tx-throttler-tablet-types flag#1368
shlomi-noach merged 9 commits intovitessio:prodfrom
timvaillancourt:vttablet-tx-throttler-tablet-types-flag

Conversation

@timvaillancourt
Copy link
Collaborator

@timvaillancourt timvaillancourt commented Jan 27, 2023

This PR adds the vttablet flag --tx-throttler-tablet-types flag to the program documentation for v16 v17

This flag is added in this PR vitessio/vitess#12174

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt force-pushed the vttablet-tx-throttler-tablet-types-flag branch from 77b2e0f to d0fa5c3 Compare January 27, 2023 16:09
@timvaillancourt timvaillancourt changed the title vttablet program: add --tx-throttler-tablet-types flag vttablet program docs: add --tx-throttler-tablet-types flag Jan 27, 2023
@netlify
Copy link

netlify bot commented Jan 27, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 85f107b
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/6466406a5b5ad500086380ff
😎 Deploy Preview https://deploy-preview-1368--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@rsajwani
Copy link
Collaborator

rsajwani commented Feb 6, 2023

Please make sure this gets push only after the PR is merge.

@harshit-gangal
Copy link
Member

This change should be done for the 17.0 doc and not for 16.0

Also, check https://vitess.io/docs/17.0/reference/features/tablet-throttler/ if this needs an update.

@harshit-gangal
Copy link
Member

Sorry for not getting to this earlier to make it to 16.0

@timvaillancourt
Copy link
Collaborator Author

Sorry for not getting to this earlier to make it to 16.0

@harshit-gangal no problem! Looks like this is ready now that vitessio/vitess#12174 is merged 👍 🙇

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@shlomi-noach shlomi-noach merged commit 34fa088 into vitessio:prod May 21, 2023
ajm188 pushed a commit that referenced this pull request Jun 26, 2023
* vttablet program: add --tx-throttler-tablet-types flag

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Fix markdown

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Reorder after change to dashes

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* "strings" plural

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Revert v16 change

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Move new flag to v17

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Fix syntax

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Plural 'strings'

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt deleted the vttablet-tx-throttler-tablet-types-flag branch August 2, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants