Update VReplication Related User Guides#1333
Merged
Merged
Conversation
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Note: add additional things such as encountering tablet control denied table related errors. Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
vrepl_user_guides
branch
from
fc16b08 to
aa36bbe
Compare
rsajwani
reviewed
Jan 5, 2023
rsajwani
left a comment
rsajwani
left a comment
Contributor
There was a problem hiding this comment.
few minor comments before I sign-off
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
vrepl_user_guides
branch
from
4e8eda2 to
fe63acf
Compare
rsajwani
approved these changes
Jan 10, 2023
Contributor
|
Approving it coz i am leaving for holiday and don't want to block you. The PR is still in draft phase but I believe you don't have any other change. If thats not true then please get sign-off from someone else as well. |
vitessio/vitess#12051 Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
vrepl_user_guides
branch
from
6784288 to
50216cc
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
vrepl_user_guides
branch
from
50216cc to
193d6dc
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
vrepl_user_guides
branch
4 times, most recently
from
72f5558 to
524e985
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
vrepl_user_guides
branch
from
524e985 to
47f20f2
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
vrepl_user_guides
branch
2 times, most recently
from
1fe9490 to
59e45e8
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
vrepl_user_guides
branch
from
59e45e8 to
dcc30a1
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
vrepl_user_guides
branch
3 times, most recently
from
a43aa86 to
e34101c
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
vrepl_user_guides
branch
from
e34101c to
66c58ff
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
rohit-nayak-ps
approved these changes
Jan 12, 2023
rohit-nayak-ps
left a comment
rohit-nayak-ps
left a comment
Member
There was a problem hiding this comment.
Great set of updates and additions!
Have noted some minor suggestions/typos, otherwise lgtm.
| customer | ||
| $ mysql --table < ../common/select_commerce_data.sql | ||
| Using commerce | ||
| Customer |
Member
There was a problem hiding this comment.
The table names are all lower case, hence we had used lower case earlier. Maybe the change is ok in the user guide, but thought I would point it out ...
Member
Author
There was a problem hiding this comment.
I'm only cutting and pasting the command output here. The capitalization is coming from the script: https://github.com/vitessio/vitess/blob/main/examples/common/select_commerce_data.sql#L3
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1234
Link: https://deploy-preview-1333--vitess.netlify.app/docs/16.0/user-guides/migration/