Skip to content

Add VStreamerCount metric from vitessio/vitess pr #11978#1291

Merged
mattlord merged 1 commit intoprodfrom
v16-VStreamerCount-metric
Dec 20, 2022
Merged

Add VStreamerCount metric from vitessio/vitess pr #11978#1291
mattlord merged 1 commit intoprodfrom
v16-VStreamerCount-metric

Conversation

@timvaillancourt
Copy link
Collaborator

This PR adds a description to metrics.md in v16 for the new VStreamerCount vreplication metric

This is planned to be added in PR vitessio/vitess#11978

cc @mattlord 🙇

@netlify
Copy link

netlify bot commented Dec 16, 2022

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit c3b8fb0
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/639cc4f13a0daf0008f76b95
😎 Deploy Preview https://deploy-preview-1291--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! https://deploy-preview-1291--vitess.netlify.app/docs/16.0/reference/vreplication/metrics/#vstreamercount

I want to get people more involved with the docs, I love this. It's a relatively easy way to contribute while also having such a major positive impact on the project and its users. 🙂 ❤️

Note we'll need to address the DCO failure before we can merge: https://github.com/vitessio/website/pull/1291/checks?check_run_id=10146299424

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt force-pushed the v16-VStreamerCount-metric branch from b7e084d to c3b8fb0 Compare December 16, 2022 19:20
@mattlord mattlord self-assigned this Dec 16, 2022
@timvaillancourt
Copy link
Collaborator Author

I want to get people more involved with the docs, I love this. It's a relatively easy way to contribute while also having such a major positive impact on the project and its users. 🙂 ❤️

Agreed! We ask contributors to add to markdown docs in github/gh-ost and it has been a pretty smooth process like this one 👍

@mattlord mattlord merged commit 5622587 into prod Dec 20, 2022
@mattlord mattlord deleted the v16-VStreamerCount-metric branch December 20, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants