Skip to content

VTOrc Documentation#1158

Merged
GuptaManan100 merged 5 commits intovitessio:prodfrom
planetscale:vtorc-docs
Oct 5, 2022
Merged

VTOrc Documentation#1158
GuptaManan100 merged 5 commits intovitessio:prodfrom
planetscale:vtorc-docs

Conversation

@GuptaManan100
Copy link
Contributor

Description

This PR does the documentation for the recent PRs -

This PR adds the documentation for upgrade instructions, flags available in VTOrc and more.

…hat from the tests

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
…-basic page

Signed-off-by: Manan Gupta <manan@planetscale.com>
@netlify
Copy link

netlify bot commented Oct 4, 2022

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 016bfbb
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/633ce6370023ba000954fd28
😎 Deploy Preview https://deploy-preview-1158--vitess.netlify.app/docs/15.0/reference/programs/vtorc
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

In order to configure `VTOrc`, you have to make the following changes to `vttablet`:

* Add `--disable_active_reparents=true`: This part will prevent vttablet from fixing replication, and will rely on vtorc instead.
* Add `--disable_active_reparents=true`: This part will prevent vttablet from fixing replication, and will rely on VTOrc instead.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still correct?
We introduced disable-replication-manager for this..
Aren't there side-effects to setting this flag? Like you can't do a PRS?
Or is it the expectation that you never have to do a PRS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable-replication-manager only disables the replication manager. disable_active_reparents also stops the tablet from initializing its own replication. Neither of these flags on the vttablet has any impact on PRS.
disable_active_reparents prevents PRS if it is specified on the vtctld server.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can use either, neither, both, everything works with VTOrc.

Copy link
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may merge this once comments are addressed.
If any further changes are needed we can make them in another PR.

Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
Signed-off-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
@GuptaManan100 GuptaManan100 merged commit 2c6bac6 into vitessio:prod Oct 5, 2022
frouioui added a commit that referenced this pull request Oct 6, 2022
Copy of changes to v16 docs from #1158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants