Conversation
…hat from the tests Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
…-basic page Signed-off-by: Manan Gupta <manan@planetscale.com>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| In order to configure `VTOrc`, you have to make the following changes to `vttablet`: | ||
|
|
||
| * Add `--disable_active_reparents=true`: This part will prevent vttablet from fixing replication, and will rely on vtorc instead. | ||
| * Add `--disable_active_reparents=true`: This part will prevent vttablet from fixing replication, and will rely on VTOrc instead. |
There was a problem hiding this comment.
Is this still correct?
We introduced disable-replication-manager for this..
Aren't there side-effects to setting this flag? Like you can't do a PRS?
Or is it the expectation that you never have to do a PRS?
There was a problem hiding this comment.
disable-replication-manager only disables the replication manager. disable_active_reparents also stops the tablet from initializing its own replication. Neither of these flags on the vttablet has any impact on PRS.
disable_active_reparents prevents PRS if it is specified on the vtctld server.
There was a problem hiding this comment.
They can use either, neither, both, everything works with VTOrc.
deepthi
left a comment
There was a problem hiding this comment.
You may merge this once comments are addressed.
If any further changes are needed we can make them in another PR.
Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Copy of changes to v16 docs from #1158
Description
This PR does the documentation for the recent PRs -
servenvstatus pages in VTOrc vitess#11263This PR adds the documentation for upgrade instructions, flags available in VTOrc and more.