Skip to content

Docs: 'cancelled' state at ALTER VITESS_MIGRATION ... CANCEL#1126

Merged
deepthi merged 1 commit intoprodfrom
docs-online-ddl-cancelled
Aug 11, 2022
Merged

Docs: 'cancelled' state at ALTER VITESS_MIGRATION ... CANCEL#1126
deepthi merged 1 commit intoprodfrom
docs-online-ddl-cancelled

Conversation

@shlomi-noach
Copy link
Copy Markdown
Contributor

This documents the changes in vitessio/vitess#10900 ; after CANCELling a migration, it transitions into cancelled state, and not to failed.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Aug 3, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 3, 2022

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 9efe92e
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/62ea16ea25e9780008ac4210
😎 Deploy Preview https://deploy-preview-1126--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shlomi-noach shlomi-noach requested a review from a team August 3, 2022 06:40
@deepthi deepthi merged commit 7f1a80b into prod Aug 11, 2022
@deepthi deepthi deleted the docs-online-ddl-cancelled branch August 11, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants