Skip to content

Document https://github.com/vitessio/vitess/pull/10639#1108

Merged
mattlord merged 1 commit intoprodfrom
vdiff2_retry
Jul 22, 2022
Merged

Document https://github.com/vitessio/vitess/pull/10639#1108
mattlord merged 1 commit intoprodfrom
vdiff2_retry

Conversation

@mattlord
Copy link
Copy Markdown
Member

@mattlord mattlord commented Jul 22, 2022

Signed-off-by: Matt Lord mattalord@gmail.com

@mattlord
Document vitessio/vitess#10639
52477fa 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Jul 22, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@mattlord mattlord mentioned this pull request Jul 22, 2022
Merged
3 tasks
@mattlord mattlord requested a review from rohit-nayak-ps July 22, 2022 01:02
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 22, 2022

✅ Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 52477fa
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/62d9f6b12a72b2000862c3a7
😎 Deploy Preview https://deploy-preview-1108--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rohit-nayak-ps
rohit-nayak-ps approved these changes Jul 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattlord mattlord merged commit 96e308d into prod Jul 22, 2022
@mattlord mattlord deleted the vdiff2_retry branch July 22, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattlord @rohit-nayak-ps