Fix data race in vtgate unit test.#962
Merged
michael-berlin merged 7 commits intovitessio:masterfrom Aug 5, 2015
Merged
Conversation
michael-berlin
force-pushed
the
fix_racy_test
branch
from
ac7d029 to
512493d
Compare
Contributor
|
This is great. Definitely will make the unit tests less flaky. (I submitted a one-line fix to a race condition I saw, should be the same fix as yours, so the merge should be easy, sorry about that). LGTM |
This fixes the problem that the wrapped integer value can be used without having to go through the interface. Fixed all unit tests where this problem occurred.
michael-berlin
force-pushed
the
fix_racy_test
branch
from
4986a02 to
f2c527a
Compare
Contributor
|
LGTM |
michael-berlin
added a commit
that referenced
this pull request
Aug 5, 2015
Fix data race in vtgate unit test.
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 19, 2022
…ssued cancellation (vitessio#11011) (vitessio#962) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed sync2.Atomic* types to make sure they cannot be used without going through the atomic interface.
@sougou @guoliang100 @alainjobart
I suggest to review commit by commit and not using the "Files changed" tab.