Merged
Conversation
Contributor
|
LGTM |
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 19, 2022
…itessio#950) * Backup/Restore: add support for external compressors and decompressors (vitessio#10558) * change to support an external decompressor Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add external compressor support + builtin additional compressors Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * wrap external compressor/decompressor Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * go mod tidy + comments Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add copyright notices Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add support for builtin engine Signed-off-by: Renan Rangel <rrangel@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Adding test case for buckup compression Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing unit test and run mod tidy Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Removing unwanted unit tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Increase timeout of backup tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing linter errors Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Change test logic to accomodate running selective tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * removing lint warning Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing test failure Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Removing un-necessary test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing code review feeback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Change builtinEngine to consider 'auto' decompressor Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing Upgrade/Downgrade test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fix type & add summary under release notes Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing typos in summary Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing flag name typos Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * cherry-pick some how didn't took the right code for test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Remove built-in decompression flag (vitessio#10670) * Remove built-in decompression flag Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fix test failures Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fix Helpoutput test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing unit test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Adding summary Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * code cleaning and better summary Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Change builtinCompressor to more generic compression engine name Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing / Adding new test case Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fix summary & static code analysis Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Adding fake backup impl in test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Adding time sleep in between test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing summary and adding comments Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Feedback on summary Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Code review feedback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing comment Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing default value in summary Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing test cases Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * More summary fixes Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing TestHelpOutput Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sougou @alainjobart
In Go 1.5, the GC will complain if it finds any pointers that point to memory that it doesn't control (for example, memory allocated within a C library). We need to hide any such pointers from the GC by giving them non-pointer types. Any interpretation of that data as a pointer must be done within C code.